[
https://issues.apache.org/jira/browse/OAK-11113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881479#comment-17881479
]
Ionut Pirlogea commented on OAK-11113:
--------------------------------------
I ran 100 times this test method and it failed randomly only once or two. There
are rans that did not failed at all.
This seems to be cause be a race condition in branch commit with collision when
executing fullGC mode for FullGCMode.ORPHANS_EMPTYPROPS_KEEP_ONE_ALL_PROPS.
We can fix the test by commenting out : store1.runBackgroundOperations() after
the code with BC but this will not fix the underlying issue that is present
randomly when running fullGC for a specific case.
Disabling store1.runBackgroundOperations() will make collision mechanism for BC
to be skipped and the test will pass.
However, the intention of the test is to verify the following scenario: node
store with unmerged BC that have collisions, and we can confirm that there is a
subtle bug in fullGC for FullGCMode.ORPHANS_EMPTYPROPS_KEEP_ONE_ALL_PROPS.
We should fix the bug first and after the test should pass.
I will close the PR with the changes for commenting out
store1.runBackgroundOperations().
> Flaky
> VersionGarbageCollectorIT.testDeletedPropsAndUnmergedBCWithCollisionWithDryRunMode
> ----------------------------------------------------------------------------------------
>
> Key: OAK-11113
> URL: https://issues.apache.org/jira/browse/OAK-11113
> Project: Jackrabbit Oak
> Issue Type: Task
> Reporter: Ionut Pirlogea
> Priority: Minor
>
> Running jenkins job failed with below error:
> [2024-08-17T23:57:55.659Z] [ERROR] Tests run: 1207, Failures: 1, Errors: 0,
> Skipped: 140, Time elapsed: 1,595.924 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT
> [2024-08-17T23:57:55.659Z] [ERROR]
> testDeletedPropsAndUnmergedBCWithCollisionWithDryRunMode[7: MongoFixture:
> MongoDB with
> ALL_ORPHANS_EMPTYPROPS](org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT)
> Time elapsed: 0.145 s <<< FAILURE! [2024-08-17T23:57:55.659Z]
> java.lang.AssertionError: document not cleaned up:
> "_children":true,"_bc":\{"r19162b449ea-0-1":"true","r19162b449e5-0-1":"true","r19162b449de-0-1":"true","r19162b449d7-0-1":"true","r19162b449c4-0-1":"true"},"_deleted":\{"r19162b44979-0-1":"false"},"_collisions":\{"r19162b449d7-0-1":"r19162b449de-0-1"},"_commitRoot":{},"_sweepRev":\{"r0-0-1":"r19162b449fc-0-1"},"_revisions":\{"r19162b449ea-0-1":"c-r19162b449fc-0-1","r19162b449e5-0-1":"br19162b449cc-0-1","r19162b449de-0-1":"br19162b449cc-0-1","r19162b449d7-0-1":"br19162b449cc-0-1","r19162b449c4-0-1":"c-r19162b449cc-0-1","r19162b4498a-0-1":"c","r19162b44979-0-1":"c"},"_id":"0:/","_modCount":21,"_modified":1723937865,"_lastRev":\{"r0-0-1":"r19162b449fc-0-1"}
> [2024-08-17T23:57:55.660Z] at org.junit.Assert.fail(Assert.java:89)
> [2024-08-17T23:57:55.660Z] at org.junit.Assert.assertTrue(Assert.java:42)
> [2024-08-17T23:57:55.660Z] at
> org.apache.jackrabbit.oak.plugins.document.FullGCHelper.assertBranchRevisionNotRemovedFromAllDocuments(FullGCHelper.java:123)
> [2024-08-17T23:57:55.660Z] at
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.testDeletedPropsAndUnmergedBCWithCollisionWithDryRunMode(VersionGarbageCollectorIT.java:2674)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
