[ 
https://issues.apache.org/jira/browse/OAK-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927916#comment-17927916
 ] 

Rishabh Daim commented on OAK-11444:
------------------------------------

I wouldn't pollute SETTINGS collection with such a huge amount of data.
Also, deleted docs & empty props aren't exactly SETTINGS, so I didn't make 
sense to save them inside SETTINGS collections.

I would propose that either we save them inside an entirely new collection 
(e.g. bin) or we should save them inside the NODES collections itself under a 
path such that they are neither accessible from UI nor from indexes.

Note: Both the above storage options should be disabled by default and behind 
an FT or OSGi config.

 

cc [~reschke] [~thomasm] 

> [full-gc] Save document id and empty properties names before deletion 
> ----------------------------------------------------------------------
>
>                 Key: OAK-11444
>                 URL: https://issues.apache.org/jira/browse/OAK-11444
>             Project: Jackrabbit Oak
>          Issue Type: Story
>          Components: mongomk
>            Reporter: Daniel Iancu
>            Priority: Major
>
> Store document ID and empty properties names into a dedicated *_bin* 
> collection
> before physically deletion  from Mongo nodes collection during full gc.
> Motivation behind this change is that in case of accidentally deleting data 
> that should have not been deleted (not garbage) this `log` of removed 
> documents and properties will help the complete restoration from backup.
> A separate collection was preferred instead of logging to files because is 
> more reliable. Logs usually needs to be exported to platform like Splunk and 
> the process does not guarantee that all logs are saved. 
> The data saved in *_bin* collection is temporary, the cleaning can be done 
> via setting document TTL or by using an external job to remove it. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to