[ 
https://issues.apache.org/jira/browse/OAK-11946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067065#comment-18067065
 ] 

Julian Reschke commented on OAK-11946:
--------------------------------------

ok:

{noformat}
diff --git 
a/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/package-info.java 
b/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/package-info.java
index a9a2f2e433..c62b51a424 100644
--- 
a/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/package-info.java
+++ 
b/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/package-info.java
@@ -19,7 +19,7 @@
  * <em>For Oak internal use only. Do not use outside Oak components.</em>
  */
 @Internal(since = "1.1.1")
-@Version("3.0")
+@Version("3.0.0")
 package org.apache.jackrabbit.oak.cache;

 import org.apache.jackrabbit.oak.commons.annotations.Internal;
{noformat}

That said, it *is* marked as "internal". So we break only the users that did 
not pay attention.

-> we need to verify that only package major versions change for "internal APIs"

FWIW, this is also why I would prefer not to use third-party API signatures in 
our API - everytime we swap out a cache library, we'd break these APIs again. 
Maybe that does not matter?

> Gradually replace Guava Cache Interfaces by Oak-specific internal APIs
> ----------------------------------------------------------------------
>
>                 Key: OAK-11946
>                 URL: https://issues.apache.org/jira/browse/OAK-11946
>             Project: Jackrabbit Oak
>          Issue Type: Task
>            Reporter: Julian Reschke
>            Assignee: Rishabh Daim
>            Priority: Major
>
> These would be identical to the Guava interfaces - modulo package names - 
> potentially stripped of unused stuff.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to