Sorry for not getting back to you sooner. The patch you sent was a bit overwhelming but had some pretty good stuff in it.
I've added preliminary 1.0a support here: http://code.google.com/p/oauth/source/detail?r=1092 I've also updated the current server/client example to (sort-of) work with 1.0a. However, I agree with you that the example really sucks and the OAuth library desperately needs better tests. Would you be willing to submit a new patch with your tests? http://code.google.com/p/oauth/issues/detail?id=113 It would be easiest for me if you made a new /tests directory with your unit tests and if you find any issues with other parts of python-oauth, to file separate tickets. Sorry if this isn't the best way to handle patches, but like I mentioned, I can get overwhelmed if there's too much stuff in a patch. Also, feel free to copyright all the unit tests as your own. We might need to get you to sign a non-assert agreement if they are accepted but it's not a big deal. Thanks! Leah Hmm... bonus points if you add four tests for the different 1.0 and 1.0a server/client combos. On Mon, Aug 3, 2009 at 6:12 PM, Rodney Dawes <[email protected]> wrote: > > Do I need to go back and make the example server/client scripts work > with the new 1.0a changes as well? Currently those scripts don't > actually implement OAuth properly anyway, and require hacking to run > if something already has the port (I think it's 8080 there) grabbed > anyway. Or can I just keep the removal of those in my patch as well? > > On Aug 3, 7:02 pm, Leah Culver <[email protected]> wrote: > > I have collected several patches for this issue (10a support) already and > > will work on this very soon (probably Wednesday). Can you please upload > the > > patch without unit tests? Please file a separate case for the unit tests. > > > > Thanks! > > Leah > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "OAuth" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/oauth?hl=en -~----------~----~----~----~------~----~------~--~---
