Did anyone try/apply this patch?  I see a couple problems that may have
to manually tweaked - these are:

> --8<-- --8<-- --8<-- --8<-- --8<-- --8<-- --8<-- --8<-- --8<-- --8<--
> 
> Index: install-db.pl
> ===================================================================
> RCS file: /src/repository/obs/install-db.pl,v
> retrieving revision 1.13
> diff -u -p -r1.13 install-db.pl
> --- install-db.pl       2000/03/27 22:57:31     1.13
> +++ install-db.pl       2001/01/23 19:50:15
> @@ -227,7 +232,7 @@ sub GetSetupInfo
>      system("stty echo");
>      print "\n";
> 
> -    $server = "localhost";
> +    $server = "localhost" unless $server ne '';
>      $db = "obs" unless $db ne '';
>      $user = "obs" unless $user ne '';

Is this logic right?  Shouldn't it be (a=b if a == '')?  I've always
found perl syntax to be the epiphany of obfuscation so I may be
misreading 'unless', but I dunno...

> Index: perl/Obs/Defs/Defs.pm.in
> ===================================================================
> RCS file: /src/repository/obs/perl/Obs/Defs/Defs.pm.in,v
> retrieving revision 1.1
> diff -u -p -r1.1 Defs.pm.in
> --- perl/Obs/Defs/Defs.pm.in    2000/03/20 06:23:47     1.1
> +++ perl/Obs/Defs/Defs.pm.in    2001/01/23 19:50:16
> @@ -14,11 +14,12 @@ use constant OBS_HOST    => "localhost";
>  use constant OBS_PORT    => 4420;
> 
>  # Database definitions
> +use constant DB_SERVER => '@OBSSERVER@';
>  use constant DB_DB => '@OBSDB@';
>  use constant DB_USER => '@OBSUSER@';
>  use constant DB_PASSWD => '@OBSPWD@';
>  use constant DB_PORT => 3306;
> -use constant DSN => 'dbi:mysql:' . Obs::Defs::DB_DB;
> +use constant DSN => 'dbi:mysql:' . Obs::Defs::DB_SERVER .':'.
> Obs::Defs::DB_DB;
^^^^^^^^^^^^^^^^^^^
        - Word Wrap error - this belongs on a single line.

regards,
Chris

-- 
Oh My God!  They Killed init!  You Bastards!!
make install; not war
_______________________________________________
Obs-dev mailing list
[EMAIL PROTECTED]
http://www.freeamp.org/mailman/listinfo/obs-dev

Reply via email to