On Wed, Dec 12, 2007 at 09:02:41AM +0800, rae l wrote: > On Dec 12, 2007 3:06 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Fri, Dec 07, 2007 at 03:21:20PM +0800, rae l wrote: > > > On Dec 7, 2007 1:12 PM, Joel Becker <[EMAIL PROTECTED]> wrote: > > > > On Fri, Dec 07, 2007 at 12:22:17PM +0800, Denis Cheng wrote: > > > > > ocfs2 uses a subsystem under sysfs: /sys/o2cb, which is not good, > > > > > > > > > > the canonical use of sysfs is one kset under /sys/fs, like the > > > > > approach > > > > > gfs2 does. > > > > > > > > > o2cb is, in theory, independent of the filesystem. Thus, it doesn't > > > > necessarily belong under /sys/fs. > > > I agree it's independent, but /sys/oc2b just don't conform the uniform > > > of the linux kernel sysfs usage. > > > > And what would that be? :) > The sysfs entries of ocfs2 are under /sys/oc2b, but I think they > generally should be under /sys/fs/oc2b, aren't they?
Yes, they should be, it looks like someone messed up putting them in the sysfs root directory. > But as Joel said, this change will break ocfs2-tools, so the decision > was not made. It should be pretty simple to change the tools to work for both places, right? thanks, greg k-h _______________________________________________ Ocfs2-devel mailing list [email protected] http://oss.oracle.com/mailman/listinfo/ocfs2-devel
