On Thu, Jun 12, 2008 at 09:40:32AM +0800, Tao Ma wrote:
> Hi Mark,
> Thanks for the review.
> I will modify it according to your suggestions.
>
> Mark Fasheh wrote:
> >The rest of this looks good. It's a big patch, but it looks good :) The
> >only
> >conern I have isn't really with your code per se, but with layout of our
> >source files. Alloc.c keeps growing... and growing... and growing... At
> >some
> >point it might be worth our while to split things out at least so that we
> >have a 'core btree operations' file.
> Yes, now alloc.c have more than 6000 lines. And maybe a new file name
> btree.c can be split out from this file that will do the real work of
> btree operation since with my patch, btree now isn't used by inode only. ;)
> I will handle this after the xattr patch is committed. Thanks.
Btree.c sounds good to me. I think maybe we can split out some parts of the
indexed btree code into their own file as well - that last patch looks
pretty big ;)
--Mark
>
> Regards,
> Tao
--
Mark Fasheh
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
