Joel is partial to generation. And you to recovery. ij_recovery_generation?
Mouthful... but we use it only in a few places.
--- Begin Message ---On Thu, Jul 10, 2008 at 05:15:44PM -0700, Joel Becker wrote: > On Thu, Jul 10, 2008 at 04:17:50PM -0700, Sunil Mushran wrote: > > This patch renames the ij_pad to ij_reco_generation in struct ocfs2_dinode. > > This new field will be used to keep the recovery counter that will > > be incremented each time the journal is replayed during fs recovery. > > > > Signed-off-by: Sunil Mushran <[EMAIL PROTECTED]> > > --- > > fs/ocfs2/ocfs2_fs.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h > > index 3633edd..e0f5459 100644 > > --- a/fs/ocfs2/ocfs2_fs.h > > +++ b/fs/ocfs2/ocfs2_fs.h > > @@ -585,7 +585,7 @@ struct ocfs2_dinode { > > struct { /* Info for journal system > > inodes */ > > __le32 ij_flags; /* Mounted, version, etc. */ > > - __le32 ij_pad; > > + __le32 ij_reco_generation; > > + __le32 ij_reco_generation; /* Recovery generation, > + incremented when the > + journal is recovered > + an unclean shutdown */ > > ... or something. And use the full word, "recovery"! If we can't stand the extra bytes, then how about "ij_recovery_count", which is actually 1 byte shorter than "ij_reco_generation" anyway... --Mark -- Mark Fasheh
--- End Message ---
_______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel
