On Thu, Jul 17, 2008 at 03:30:18PM -0700, Joel Becker wrote: > On Thu, Jul 17, 2008 at 02:45:12PM -0700, Joel Becker wrote: > > On Thu, Jul 17, 2008 at 02:20:38PM -0700, Joel Becker wrote: > > > On Thu, Jul 17, 2008 at 11:01:40AM -0700, Linus Torvalds wrote: > > > > I pulled it, but I want to register my protest. > > > > > > I wish you hadn't, because it won't be to difficult to go back > > > to PTR_ERR(). However, don't revert it - that affects some of the > > > follow-on patches that were affected by the change. > > > > I lied. I'll cleanup the fallout. You can revert it or wait > > for my revert + PTR_ERR. Let me know if you revert it. > > Linus, > Pull this to get the revert and the PTR_ERR() version: > > git://oss.oracle.com/git/jlbec/linux-2.6.git configfs-fixup-ptr-error > > It's tested with the same testing I did before - ocfs2 and netconsole.
While this new version looks ok, it seems that it still allows client subsystems to return NULL in ->make_group()/->make_item(), in which case configfs_mkdir() turns the result into -ENOMEM. Maybe this is intended to smoothly update out-of-tree subsystems? I'd suggest to schedule a removal of this backward compatibility, and display an error log to encourage fixing the subsystems that still return NULL. Louis -- Dr Louis Rilling Kerlabs - IRISA Skype: louis.rilling Campus Universitaire de Beaulieu Phone: (+33|0) 2 99 84 71 52 Avenue du General Leclerc Fax: (+33|0) 2 99 84 71 71 35042 Rennes CEDEX - France http://www.kerlabs.com/
signature.asc
Description: Digital signature
_______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel
