On Thu, Jul 31, 2008 at 09:40:21PM +0800, Coly Li wrote:
> diff --git a/mount.ocfs2/mount.ocfs2.c b/mount.ocfs2/mount.ocfs2.c
> index a97b4cb..eb8e336 100644
> --- a/mount.ocfs2/mount.ocfs2.c
> +++ b/mount.ocfs2/mount.ocfs2.c
> @@ -382,9 +382,21 @@ int main(int argc, char **argv)
> o2cb_complete_group_join(&cluster, &desc, errno);
> }
> block_signals (SIG_UNBLOCK);
> - com_err(progname, ret, "while mounting %s on %s. "
> - "Check 'dmesg' for more information on this error.",
> - mo.dev, mo.dir);
> +
> + /* complain mount failure */
> + if (lstat(mo.dir, &statbuf))
> + com_err(progname, 0, "mount point %s does not "
> + "exist", mo.dir);
> + else if (stat(mo.dir, &statbuf))
> + com_err(progname, 0, "mount point %s is a "
> + "symbolic link to nowhere", mo.dir);
> + else if (stat(mo.dir, &statbuf) || !S_ISDIR(statbuf.st_mode))
+ else if (!S_ISDIR(statbuf.st_mode))
You successfully called stat in the previous "else if" clause.
> + com_err(progname, 0, "mount point %s is not "
> + "a directory", mo.dir);
> + else
> + com_err(progname, ret, "while mounting %s on %s. "
> + "Check 'dmesg' for more information on this "
> + "error.", mo.dev, mo.dir);
Also, I agree with sunil's "broken symbolic link" text.
Joel
--
"I have never let my schooling interfere with my education."
- Mark Twain
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
