On Mon, Oct 20, 2008 at 07:23:36PM +0200, Jan Kara wrote:
> Checks like <= 0 for an unsigned type do not make much sence. The value
> could be only 0 and that does not happen often enough for the check
> to be worth it.
Why not worth it? Certainly the '<' isn't valid, but is it even
possible to call these functions with 0? I don't know enough to answer
that, but I'm wondering if it should BUG_ON(inodes == 0). If not, what
happens after this change? Obviously inodes==0 means the quota doesn't
change, but could they get a soft warning they wouldn't get before?
Joel
--
Life's Little Instruction Book #222
"Think twice before burdening a friend with a secret."
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
