On Mon, Oct 20, 2008 at 07:23:59PM +0200, Jan Kara wrote:
> Enable quota usage tracking on mount and disable it on umount. Also
> add support for quota on and quota off quotactls and usrquota and
> grpquota mount options.
>
> Signed-off-by: Jan Kara <[EMAIL PROTECTED]>
> ---
Looks good, with one small comment.
> @@ -660,6 +798,22 @@ static int ocfs2_fill_super(struct super_block *sb, void
> *data, int silent)
> osb->preferred_slot = parsed_options.slot;
> osb->osb_commit_interval = parsed_options.commit_interval;
> osb->local_alloc_size = parsed_options.localalloc_opt;
> + if (osb->s_mount_opt & OCFS2_MOUNT_USRQUOTA &&
> + !OCFS2_HAS_RO_COMPAT_FEATURE(sb,
> + OCFS2_FEATURE_RO_COMPAT_USRQUOTA)) {
> + status = -EINVAL;
> + mlog(ML_ERROR, "User quota requested but filesystem feature "
> + "is not set\n");
Can we say "User quotas were requested, but this filesystem does not
have the feature enabled.\n"? The same for group quotas.
Joel
--
"Nothing is wrong with California that a rise in the ocean level
wouldn't cure."
- Ross MacDonald
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
