On Wed, Nov 05, 2008 at 07:25:23AM +0800, Tao Ma wrote:
> Modification from V1 to V2:
> 1. Some typo fix from Joel.
> 2. Adjust ocfs2_free_cached_clusters to handle the situation of
> truncate log full. Most of codes are copied from
> ocfs2_complete_truncate_log_recovery.
Looking good, one comment.
> @@ -5920,6 +6001,15 @@ int ocfs2_run_deallocs(struct ocfs2_super *osb,
> kfree(fl);
> }
>
> + if (ctxt->c_global_allocator) {
> + ret2 = ocfs2_free_cached_clusters(osb,
> + ctxt->c_global_allocator);
> + if (ret2)
> + mlog_errno(ret2);
> + if (!ret)
> + ret = ret2;
Be sure to set ctxt->c_global_allocator to NULL here; The block
free list ends in a NULL, so c_first_suballocator ends up as NULL. This
cluster list should be set NULL too after free_cached_clusters()
returns.
Otherwise, this patch is good to go.
Joel
--
"The nice thing about egotists is that they don't talk about other
people."
- Lucille S. Harper
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
