On Thu, Nov 27, 2008 at 10:10:38AM +0800, Tao Ma wrote:
> Joel Becker wrote:
>> Now that ocfs2_mv_xattr_buckets() can move a partial cluster's worth of
>> buckets, ocfs2_mv_xattr_bucket_cross_cluster() can use it.
<snip>
>> - ret = ocfs2_read_xattr_bucket(old_first, src_blkno);
>> + ret = ocfs2_read_xattr_bucket(new_first, src_blkno);
>> + if (ret) {
>> + mlog_errno(ret);
>> + goto out;
>> + }
> here should read new_blkno since "new_first" means the first bucket of
> the new cluster(I guess that from the code you removed).
I was hoping you'd notice that :-) I saw it when reviewing
the emailed patches, and I've already fixed it in my git tree.
Joel
--
"People with narrow minds usually have broad tongues."
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
