On Wed, Dec 10, 2008 at 01:54:51PM +0100, Andi Kleen wrote:
> Joel Becker <[EMAIL PROTECTED]> writes:
>
> > These patches add the metadata ECC code to ocfs2. They have one
> > limitation - they do not ECC directory blocks yet. However, that will
> > only take a simple insertion of the dirblock trailer. With xattr ECC
> > completed, the patches are approaching a final form and are ready for
> > initial review. They are atop my xattr-buckets-2 branch.
>
> Could you please expand a bit why you chose ECC over more standard CRCs?
>
> My assumption would be normally that if there is disk corruption it won't
> be single flipped bits, but more large scale corruption. Do you have
> data/experiences on the contrary?
If you look at our block_check structure, you'll see that it
uses crc32c for the overall block, and then the ECC can attempt to
correct a single bit if the crc fails.
Joel
--
"If the human brain were so simple we could understand it, we would
be so simple that we could not."
- W. A. Clouston
Joel Becker
Principal Software Developer
Oracle
E-mail: [EMAIL PROTECTED]
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
