On Sun, Aug 15, 2010 at 10:36:36PM -0500, Eric Sandeen wrote:
> Er, yeah. I had 32 bits in my head since that's the case we're
> checking for... whoops.
>
> So I guess your
>
> ... ||
> ((last_fs_block >> (PAGE_CACHE_SHIFT - blocksize_bits)) >
> (pgoff_t)(!0ULL))) {
>
> is right :) (my feeble brain has a hard time reading that, though, TBH)
Well, note the bug in my quickly typed version: "(!0ULL)" vs
"(~0ULL)". How about:
u64 last_fs_page = last_fs_block >> (PAGE_CACHE_SHIFT - blocksize_bits);
... ||
(last_fs_page > (pgoff_t)(~0ULL))) {
Is that more readable?
Joel
--
Life's Little Instruction Book #99
"Think big thoughts, but relish small pleasures."
Joel Becker
Consulting Software Developer
Oracle
E-mail: [email protected]
Phone: (650) 506-8127
_______________________________________________
Ocfs2-devel mailing list
[email protected]
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
