On 10/08/2010 04:11 PM, Mark Fasheh wrote:
>> /*00*/ __u8 ci_stack[OCFS2_STACK_LABEL_LEN];
>> - __le32 ci_reserved;
>> + union {
>> + __le32 ci_reserved;
>> + struct {
>> + __u8 ci_reserved1;
>> + __u8 ci_reserved2;
>> + __u8 ci_reserved3;
>> + __u8 ci_stackflags;
>>
> Just curious, why stick ci_stackflags at the bottom of this structure?
>
> Wouldn't putting it at the top allow us to grow the field in the future...
>
> Otherwise the patch looks good to me.
>
Grow stackflags? Hmm... did not think of that.
I don't have a good reason for putting it at the end. Well,
when I put it, I thought I did. Not anymore.
If we have to make the change, I'll have to do it asap. We have
a very short window. Let me know if you feel that the change
is a must-do.
Sunil
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel
