On 05/24/2013 02:20 PM, xiaowei.hu wrote: > Should we also add this (status != -ENOTEMPTY) in end of ocfs2_rename? > It also may hit this unecessary error.
This definitely is the same thing like ocfs2_unlink() that need to be fixed. Thanks, -Jeff > > Thanks, > xiaowei > > On 05/20/2013 11:06 PM, Goldwyn Rodrigues wrote: >> While removing a non-empty directory, the kernel dumps a message: >> (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39 >> >> Suppress the error message from being printed in the dmesg so users >> don't panic. >> >> Signed-off-by: Goldwyn Rodrigues <[email protected]> >> >> --- >> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c >> index 04ee1b5..33c7b91 100644 >> --- a/fs/ocfs2/namei.c >> +++ b/fs/ocfs2/namei.c >> @@ -947,7 +947,7 @@ leave: >> ocfs2_free_dir_lookup_result(&orphan_insert); >> ocfs2_free_dir_lookup_result(&lookup); >> >> - if (status) >> + if (status && (status != -ENOTEMPTY)) >> mlog_errno(status); >> >> return status; >> >> _______________________________________________ >> Ocfs2-devel mailing list >> [email protected] >> https://oss.oracle.com/mailman/listinfo/ocfs2-devel >> >> > > > _______________________________________________ > Ocfs2-devel mailing list > [email protected] > https://oss.oracle.com/mailman/listinfo/ocfs2-devel _______________________________________________ Ocfs2-devel mailing list [email protected] https://oss.oracle.com/mailman/listinfo/ocfs2-devel
