On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn <daeseok.y...@gmail.com> wrote:
> The use of 'status' in __ocfs2_add_entry() can return wrong
> status when some functions are failed.
>
> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed,
> that status is saved to 'status' but return variable is 'retval'
> which is saved 'success' status. In case of this, __ocfs2_add_entry()
> is failed but can be returned as 'success'.
>
> So replace 'status' with 'retval'.
>
> - mlog_errno(status);
> + if (retval) {
> + mlog_errno(retval);
> goto bail;
and
bail:
if (retval)
mlog_errno(retval);
return retval;
}
so we'll clearly log the same error twice.
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
