Hi Mark,
On 2015/8/29 7:55, Mark Fasheh wrote:
> On Wed, Aug 26, 2015 at 03:11:48PM -0700, Andrew Morton wrote:
>> From: Xue jiufei <xuejiu...@huawei.com>
>> Subject: ocfs2: extend enough credits for freeing one truncate record while
>> replaying truncate records
>>
>> Now function ocfs2_replay_truncate_records() first modifies tl_used, then
>> calls ocfs2_extend_trans() to extend transactions for gd and alloc inode
>> used for freeing clusters. jbd2_journal_restart() may be called and it
>> may happen that tl_used in truncate log is decreased but the clusters are
>> not freed, which means these clusters are lost. So we should avoid
>> extending transactions in these two operations.
>>
>> Signed-off-by: joyce.xue <xuejiu...@huawei.com>
>> Cc: Mark Fasheh <mfas...@suse.com>
>> Cc: Joel Becker <jl...@evilplan.org>
>> Signed-off-by: Andrew Morton <a...@linux-foundation.org>
>> ---
>>
>> fs/ocfs2/alloc.c | 19 ++++++++-----------
>> 1 file changed, 8 insertions(+), 11 deletions(-)
>>
>> diff -puN
>> fs/ocfs2/alloc.c~extend-enough-credits-for-freeing-one-truncate-record-while-replaying-truncate-records
>> fs/ocfs2/alloc.c
>> ---
>> a/fs/ocfs2/alloc.c~extend-enough-credits-for-freeing-one-truncate-record-while-replaying-truncate-records
>> +++ a/fs/ocfs2/alloc.c
>
> <looks good>
>
>> @@ -6063,7 +6060,7 @@ int __ocfs2_flush_truncate_log(struct oc
>> goto out_mutex;
>> }
>>
>> - handle = ocfs2_start_trans(osb, OCFS2_TRUNCATE_LOG_UPDATE);
>> + handle = ocfs2_start_trans(osb, OCFS2_TRUNCATE_LOG_FLUSH_ONE_REC);
>> if (IS_ERR(handle)) {
>> status = PTR_ERR(handle);
>> mlog_errno(status);
>
> Why is this particular change here?
> --Mark
>
I think Joyce wants to get enough credits at first and then call
ocfs2_replay_truncate_records.
Thanks
Joseph
> --
> Mark Fasheh
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>
>
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
