Hello Andrew,
>>> > On Fri, 25 Dec 2015 15:16:16 +0800 Gang He <g...@suse.com> wrote: > >> Export ocfs2_kset object from ocfs2_stackglue kernel module, >> then online file check code will create the related sysfiles >> under ocfs2_kset object. >> >> ... >> >> --- a/fs/ocfs2/stackglue.c >> +++ b/fs/ocfs2/stackglue.c >> @@ -629,7 +629,8 @@ static struct attribute_group ocfs2_attr_group = { >> .attrs = ocfs2_attrs, >> }; >> >> -static struct kset *ocfs2_kset; >> +struct kset *ocfs2_kset; >> +EXPORT_SYMBOL_GPL(ocfs2_kset); > > The EXPORT_SYMBOL is only needed if this symbol is to be referred to > from a different module. That isn't the case here - everything which > refers to ocfs2_kset is linked into ocfs2.ko, correct? There are some kernel modules (Not single KO file) for OCFS2 file system, the variable ocfs2_kset is located in ocfs2_stackglue.ko kernel module, if the main kernel module ocfs2.ko wants to refer to this variable, it looks to have to export this symbol? Thanks Gang _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel