On 2016/3/14 20:21, Joseph Qi wrote:
> On 2016/3/14 19:57, piaojun wrote:
>> In dlm_send_join_cancels(), unsigned int node is assigned -1, this will
>> lead variable overflow. Although this won't cause any runtime problem,
>> the code looks a little uncoordinated.
>>
>> Signed-off-by: Jun Piao <piao...@huawei.com>
>> Reviewed-by: Joseph Qi <joseph...@huawei.com>
>> ---
>> dlm/dlmdomain.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c
>> index 2ee7fe7..61bafa7 100644
>> --- a/dlm/dlmdomain.c
>> +++ b/dlm/dlmdomain.c
>> @@ -1395,8 +1395,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm,
>> unsigned long *node_map,
>> unsigned int map_size)
>> {
>> - int status, tmpstat;
>> - unsigned int node;
>> + int status, tmpstat, int node;
> This is not right. NAK.
>
Hi Joseph Qi, Thanks for your prompt, I have sent a V2 patch to fix this.
>>
>> if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) *
>> sizeof(unsigned long))) {
>>
>
>
>
> .
>
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
