fre, 25 01 2008 kl. 08:32 -0600, skrev Muthiah Annamalai: > Tribo Laboy wrote: > > On Jan 25, 2008 1:48 PM, Muthiah Annamalai <[EMAIL PROTECTED]> wrote: > > > > > >> I dont know if I must gohead and make the change. Maybe you > >> should report a warning instead. > >> > >> using the builtin function: warning, for this and send another > >> patch. > >> > > > > > > Hi Muthu, > > > > Issuing a warning is OK with me. However according to the FAQ "in > > general differences between the two (Octave and MATLAB) are considered > > as bugs." As a bug it needs to be fixed, the behaviour changed and and > > the change reflected in the next release notes (and in a warning > > inside the function) for the benefit of users who relied on the past > > behaviour. (I, personally, find the Octave behaviour much more > > sensible, but that's a different matter.) BTW, do we have a place > > where we can write the release notes and changes for the upcoming > > package releases? > > > > Did I convince you? > > > > Now the issue is how to word the warning. > > > > It should be helpful to have something like: > > > > "Warning! Syntax of DOWNSAMPLE was changed since version 1.0.5 of the > > signal package. See the release notes for details." > > > > TL > > > I think your warning message could also say phase variable behavior in > Matlab & Octave differ. > > I'm afraid I'm not the best person to resolve this problem. Maybe David > or Soren > must step in and resolve it. I can commit the patch thought if they OK it. I don't know the 'downsample' function so I don't really have any strong feelings here. In general we try to be compatible with Matlab, so if that patch improves situation for the 'downsample' function, then I'd say go ahead and apply it. But my opinion doesn't really matter here since I don't know the function... So, those of you who actually use the function, could you decide on a reasonable behaviour and patch the function?
Søren ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Octave-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/octave-dev
