> > I have committed main/signal/src/sosfilt.cc.
> > I have changed the code according to your suggestions.
> > main/signal/src/Makefile changed accordingly.
> I believe the signal package contains an INDEX file. This is a file that
> categorises the functions in the package. Could you edit this file, and
> add 'sosfilt' to fitting category?
grep -n sosfilt INDEX
29: sosfilt
sosfilt was there already!? in category Filtering which is fine.
=============================================================
and oups, forgot to Cc the following message to the list as well. corrected now.
I have committed main/signal/src/sosfilt.cc.
I have changed the code according to your suggestions.
main/signal/src/Makefile changed accordingly.
regarding the upgrade of resample.m, I will wait for
the green light from the developpers that are
concerned by this change. I'll make the changes
you suggest in your earlier message.
cheers, eric.
> *) You should add a version to the GPL. Since Octave is licensed under
> GPLv3 or later, I recommend that you do the same.
> *) You type 'using namespace std' two times.
> *) You should as a minimum state what arguments you function accepts,
> and what it returns, in the help text. But it would be nice if you
> wrote something more elaborate.
> *) You need to handle the situation where the user supplies input arguments
> of the wrong type (as an example, I think your code will crash Octave if
> your function is called with a 'struct' as input). You can check this using
> if (error_state) { error("Bad input"); return octave_value_list; }
> after extracting values from an octave_value.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
