On Fri, May 2, 2008 at 2:42 PM, Tatsuro MATSUOKA <[EMAIL PROTECTED]> wrote: > Hello Xavier > > > --- Xavier Delacour <[EMAIL PROTECTED]> wrote: > > Right, I'll have a look and submit a fix in the next few days. > > > > I didn't get a patch, btw. Maybe you could resend it to me personally. > > > > Xavier > > Quentin's patch was sent by an attachment file. > So I cite here in a mail body.
I didn't receive an attachment. The message was sent directly to you, whereas I got it through the list. That may explain why. In any case, Quentin sent me the patch in a separate email. > However it seems to be a quick hack for his system. Yes, I understand that, however he mentioned some issues with missing header decls, which I wouldn't expect to be mkoctfile related. > Octave-forge packages should be built in the same compling environments as > that octave themselves. > Even for Linux, there shoud be users like Intel c, fortran, c++. > Octave-forge packages should consider that. I will submit a fix so the imported ANN package uses mkoctfile. The bindings portion of the package already works that way. Thanks, Xavier > > Please use information of aquired from mkoctfile or use mkoctfile itself to > build package. > The mkoctfile script can be used like a complier > > -c, --compile Compile, but do not link. > > -o FILE, --output FILE Output file name. Default extension is .oct > (or .mex if --mex is specified) unless linking > a stand-alone executable. > > For details, please read mkoctfile --help. > > Regards > > Tatsuro > > ****************************************** > diff -ur > octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/ann2fig/ann2fig.cpp > octave-forge-bundle-20080429/main/ann-1.0/src/ann/ann2fig/ann2fig.cpp > --- > octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/ann2fig/ann2fig.cpp > 2008-04-28 > 12:08:50.000000000 -0500 > +++ octave-forge-bundle-20080429/main/ann-1.0/src/ann/ann2fig/ann2fig.cpp > 2008-05-01 > 12:48:01.000000000 -0500 > @@ -42,7 +42,8 @@ > > #include <cstdio> // C > standard I/O > #include <fstream> // file I/O > -#include <string> // string > manipulation > +#include <cstring> // string > manipulation > +#include <cstdlib> > #include <ANN/ANNx.h> // all ANN includes > > using namespace std; // make std:: > accessible > diff -ur > octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/bindings/ann_wrap.cpp > octave-forge-bundle-20080429/main/ann-1.0/src/ann/bindings/ann_wrap.cpp > --- > octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/bindings/ann_wrap.cpp > 2008-04-28 > 12:08:55.000000000 -0500 > +++ octave-forge-bundle-20080429/main/ann-1.0/src/ann/bindings/ann_wrap.cpp > 2008-05-01 > 12:48:01.000000000 -0500 > @@ -8,6 +8,8 @@ > * interface file instead. > * > ----------------------------------------------------------------------------- > */ > > +#include <cstring> > + > #define SWIG_name_d "ann" > #define SWIG_name ann > > diff -ur octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/Make-config > octave-forge-bundle-20080429/main/ann-1.0/src/ann/Make-config > --- octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/Make-config > 2008-04-28 12:08:55.000000000 > -0500 > +++ octave-forge-bundle-20080429/main/ann-1.0/src/ann/Make-config > 2008-05-01 12:48:38.000000000 -0500 > @@ -72,7 +72,7 @@ > $(MAKE) targets \ > > "ANNLIB = libANN.a" \ > "C++ = g++" \ > - "CFLAGS = -O3" \ > + "CFLAGS = -fPIC -O3" \ > > "MAKELIB = ar ruv" \ > "RANLIB = true" > > diff -ur > octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/src/kd_dump.cpp > octave-forge-bundle-20080429/main/ann-1.0/src/ann/src/kd_dump.cpp > --- octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/src/kd_dump.cpp > 2008-04-28 > 12:08:54.000000000 -0500 > +++ octave-forge-bundle-20080429/main/ann-1.0/src/ann/src/kd_dump.cpp > 2008-05-01 12:48:01.000000000 > -0500 > @@ -33,6 +33,8 @@ > > #include "kd_tree.h" // kd-tree > declarations > #include "bd_tree.h" // bd-tree > declarations > +#include <cstdlib> > +#include <cstring> > > using namespace std; // make std:: > available > > diff -ur > octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/test/ann_test.cpp > octave-forge-bundle-20080429/main/ann-1.0/src/ann/test/ann_test.cpp > --- octave-forge-bundle-20080429.orig/main/ann-1.0/src/ann/test/ann_test.cpp > 2008-04-28 > 12:08:50.000000000 -0500 > +++ octave-forge-bundle-20080429/main/ann-1.0/src/ann/test/ann_test.cpp > 2008-05-01 12:48:01.000000000 > -0500 > @@ -36,8 +36,9 @@ > > #include <ctime> // clock > #include <cmath> // math > routines > -#include <string> // C string > ops > +#include <cstring> // C string > ops > #include <fstream> // file I/O > +#include <cstdlib> > > #include <ANN/ANN.h> // ANN declarations > #include <ANN/ANNx.h> // more ANN > declarations > > > > > > > > -------------------------------------- > GANBARE! NIPPON! Win your ticket to Olympic Games 2008. > http://pr.mail.yahoo.co.jp/ganbare-nippon/ > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Octave-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/octave-dev
