Eric Chassande-Mottin wrote:
> 
> I have written a function (
> http://www.nabble.com/file/p18490379/fracshift.m code attached,
> fracshift.m ) which performs the shift of a data vector
> (e.g., a time-series) by a fractional number of samples. this is useful
> in area such as antenna array processing and possibly 
> others (processing of stereo audio signals?). It is fairly
> well documented, has the GPL and include three sanity checks.
> 

Cute, and I can see the use of such a function for clock offset calculations
in comms systems. I typically use simpler narrwband approximations for this
functionality as I have to worry about how to implement it on an ASIC. 

The interpolator must introduce a colored noise to the signal, that depends
on the signal given to the function, and the characteristics of the
interpolating filter. Have you any idea of the magnitude of the error
introduced with the default filter? If so it would probably makes sense to
document it in the help string so that others kno what to expect. I'd check
myself, but am writing from an EEE PC without a copy of Octave installed to
check with.

A couple of comments on the code itself, could you move the copyright to
above the function definition, and the help text immediately following it
with a single blank line between the copyright and the help text. This will
be more consistent with the rest of Octave.



> As far as I know, there is no equivalent in the matlab world.
> I would fit in the signal toolbox. Would you agree if I include it
> there?
> 

seems like a good thing. I'd say go ahead and commit it.

D.

-- 
View this message in context: 
http://www.nabble.com/shift-of-a-fractional-number-of-samples-tp18490379p18491908.html
Sent from the octave-dev mailing list archive at Nabble.com.


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to