Hi,
fre, 09 01 2009 kl. 09:13 -0500, skrev David:
> As promised, here's a copy of my code so far, but I still have a lot
> to do. I still have all the functions in one file, but I will split it
> up by function eventually. Also, I have to add some test scaffolding
> to exercise all the functions, and more extensive examples. However,
> I've attached a few examples as well. (If the attachments don't get
> through, please let me know.)
A brief look at your code tells me that things look nice :-)
I don't have much experience with Music, so I cannot comment on the API.
Anyway, if you post your sourceforge id I can give you commit access to
SVN, such that you can upload your code. But please split your functions
into individual files before uploading. If you need help with the
directory structure, etc., just speak up on the list.
> I'm still learning Octave/Matlib, so there are probably a lot of
> improvements that could be made, and maybe some bugs in my code too.
> Any suggestions or advice would be appreciated.
Your accessor functions all seem to follow the same structure. An
example is 'ML_REFFREQ' which looks like this:
mlock();
try
ml_reffreq;
catch
persistent ml_reffreq = 440;
end
old = ml_reffreq;
if (nargin == 1)
ml_reffreq = new;
endif
I don't see why you need the try-catch block. Doesn't the following
work:
mlock();
persistent ml_reffreq = 440;
old = ml_reffreq;
if (nargin == 1)
ml_reffreq = new;
endif
?
Also, in your TODO you mention that you need to implement convolution.
Can't users just call the 'conv' function? Do you really need your own
function for this?
Søren
>
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
