Hi,
This is my SourceForge information:
Username: shuhua
Publicly displayed name: Shuhua Zhang
Registered email address: shuhua.zh...@gmail.com
Thanks a lot.
Regards,
Shuhua Zhang, Aug. 2, 2009
On Sun, Aug 2, 2009 at 12:26 AM, Søren Hauberg <so...@hauberg.org> wrote:
> Hi
>
> Thanks a bunch for fixing this. If you send your SourceForge login to
> this list, I will give you commit access to SVN. This will allow you to
> add the code yourself.
>
> Søren
>
> søn, 02 08 2009 kl. 00:05 +0800, skrev Shuhua Zhang:
> > Hi,
> >
> > Many thanks for your suggestions.
> > I have replaced the abbreviations (MDCT/IMDCT) with the full
> > names,
> > and added the GPL header to the codes.
> >
> > Regards,
> >
> > Shuhua Zhang, Aug. 1, 2009
> >
> >
> > On Sat, Aug 1, 2009 at 4:10 PM, Søren Hauberg <so...@hauberg.org>
> > wrote:
> > Hi
> >
> > fre, 31 07 2009 kl. 21:30 +0800, skrev Shuhua Zhang:
> > > I do research in digital audio compression,
> > > so times need mdct and imdct transform,
> > > which is the most widely used one in audo coding,
> > > such as MP3, AAC, OGG Vorbis, WMA.
> > >
> > > Here I post my codes for the two transforms as
> > > well as a funtion to generate KBD window for AAC.
> >
> >
> > This code looks good to me. I have a few comments:
> >
> > 1) You need to add license information to the code. If you
> > release the
> > code under the GPL that means you have to add the standard GPL
> > header to
> > each file. Similarly if you choose another license.
> >
> > 2) When you use abbreviations in the documentation (like MDCT)
> > it would
> > be nice if write what it stands for. That is, write
> >
> > % IMDCT Compute the Inverse Modified Cosine Transform
> > (IMDCT)
> > through FFT
> >
> > instead of
> >
> > % IMDCT Compute IMDCT through FFT
> >
> > But besides these minor issues things look good. Please fix
> > these and
> > resend the code to this list (it is really important that we
> > make sure
> > the license information is correct).
> >
> > Søren
> >
> >
> >
> ------------------------------------------------------------------------------
> > Let Crystal Reports handle the reporting - Free Crystal Reports 2008
> 30-Day
> > trial. Simplify your report design, integration and deployment - and
> focus on
> > what you do best, core application coding. Discover what's new with
> > Crystal Reports now. http://p.sf.net/sfu/bobj-july
> > _______________________________________________ Octave-dev mailing list
> Octave-dev@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/octave-dev
>
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
