On 22.10.2009, at 15:42, Luca Favatella wrote: > On 22/10/2009, Lukas Reichlin <[email protected]> wrote: > [...] >> Legacy files in [0] are the ported (*) ones, e.g. the lqr command. I > [...] >> (*) ported means that they accept the new system format and use only >> "official" functions from LTI Syncope internally. > > Great, you already ported some functions! > > [...] >> Maybe I should add a tag to each legacy file to simplify >> identification: >> ## Adapted-By: Lukas Reichlin >> ## Created: October 2009 >> ## Version: 0.1 >> >> Please let me know if you have any further questions or suggestions. > > Let's consider lyap.m [0]: it does not depend on the system format. > But you copied it [1] from the legacy package [2], adding > * 2 white spaces > * tag "Adapted-By" (even if it didn't need adaptation...)
Oops, that's really a stupid mistake :-) I have to admit that I did some quick "batch" adding for 19 files (revision 6355) and didn't pay attention to whether I really changed the code ... > > This is what I'd like to avoid: having the same script copied in 2 > places even if not needed. I see your point. > > I think functions not needing porting should stay only in the legacy > package and be improved there if needed, until the rewritten package > becomes the official package. > Keeping in the rewritten package a text file with the list of these > functions could also be useful. > You are right. Regards, Lukas > > Cheers, > Luca Favatella > > > > > [0] BTW, lyap is Scilab-compatible but not Matlab-compatible. I didn't > change it one year ago for backard compatibility concerns. > > [1] > http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/extra/control-oo/inst/control/lyap.m?revision=6355 > > [2] > http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/control/inst/lyap.m?revision=6355 ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Octave-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/octave-dev
