Thank you, we will fix the points 1 and 3 immediately... But what about the point 2? Should we put the source code and the build instructions in the src directory?
Thanks Il 17/01/2011 19:34, David Grundberg ha scritto: > Gianvito Pio skrev: >> No problem, here you can download the entire package we would like to send: >> http://dl.dropbox.com/u/8633823/fl-core-1.0.tar.gz >> >> Please let us know. >> Gianvito Pio > I've taken a quick(!) look at it and there are several things that might > be a problem: > > 1. 'help fl_complement' displays the copyright header instead of the > help text. This is fixed by starting the file with "% Copyright ..." > instead of "% flcore ...". > > 2. Distribution of GNU LGPL binary executable with neither source code > nor build instructions. (pthreadVC2.dll). > > 3. Hardcoded texinfo-like information. This is a nit-pick, and isn't > required for inclusion in OctaveForge, but it looks like you wanted to > accomplish Octave-like output and I thought I'd tell you how to do it > for serious. > > You currently have: > > function res = fl_cartproduct(A, B, T= "min") > % -- Loadable Function: fl_cartproduct(A, B) > % -- Loadable Function: fl_cartproduct(A, B, T) > % > > which can be done like (yes, I'm lazy, this is from imread.m): > > ## -*- texinfo -*- > ## @deftypefn {Function File} {[@var{img}, @var{map}, @var{alpha}] =} > imread (@var{filename}) > ## Read images from various file formats. > > If you format it using texinfo you can delete lines like > > usage_message = "Invalid call to fl_cartproduct."; > error(usage_message); > > and just do this instead: > > print_usage (); > > Cheers, > Grundberg > ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
