tir, 10 05 2011 kl. 18:43 -0400, skrev Joe Romano:
> Hello All,

I apologize for the late reply, but man-power is a scarce resource
around here.

> I have hacked my local version of levinson.m to add in this feature,
> and tested it's compatibility with the Matlab implementation. It is
> attached to this email.

Cool! Thanks for working on this.

> I am new to Octave and the developer list, so
> I apologize in advance for not following whatever the 'norm' protocol
> is. If someone is interested in responding to tell me how I can best
> add in this fix to the codebase myself I'd be happy to do so.

We try to review suggested changes before committing them. For this
reason it is helpful for us to have a list of your changes. This can be
generated using the 'diff' command on Unix operating systems. So, if you
can generate a patch using diff that shows the suggested changes it
makes reviewing much more easy. I tried doing this with the code you
sent, but it seems like you changed many things that did not need to be
changed (like adding % in front of comment lines). This made it too hard
for me to follow the list of changes. Can you generate a patch that is
as simple as possible, while still containing the changes you want?

Thanks
Søren


------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Octave-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to