Carnë Draug wrote:
> Hi Philip,
>
> an user (Juan Pablo Carbajal) has recently submitted some new
> functions for inclusion in octave-forge to load SVG files. While in
> the original request he mentioned the image package, I have recently
> talked to him on #octave and he mentioned maybe the IO package would
> be more appropriate. I was going to commit them to the package but
> would like to know if you find them suitable for inclusion on the
> package since you are its maintainer. They can be downloaded from the
> feature request tracker on SF
> https://sourceforge.net/tracker/download.php?group_id=2888&atid=352888&file_id=423885&aid=3410112
Having had a quick look, I wouldn't be sure what the best place would be.
Are the returned SVG structures only, or predominantly, useful within
the scope of image processing?
=> if Yes, IMO the image pkg would be more appropriate
=> if No, the io pkg could be used.
In either case a separate "svg" section would be appropriate.
Regardless of what the files do, I don't know what they are used for, or
can be used for, or are intended to be used for, so I can't maintain
them anyway.
But OK let's say I only maintain the "package" (= the "container") :-)
Yet if they are to go in the io pkg, I have some remarks:
If I were Juan I would add some error catching around fopen statements
in loadSVG and perhaps around the strread in getSVG. Just advice.
Does Juan wants them to remain Matlab-compatible (noting the "%" comment
lines)? if so won't ML complain about the texinfo stuff and the series
of %% comment lines? (each one is a different section in ML's editor)
I would like the files to comply a little bit more to coding standards, i.e.
- space between arguments after commas
- space between function calls and left paren but not between variable
names and indices
- spaces around operators
all of this for better readability.
("a bit more" because I think the style is already quite good)
In addition I don't like uppercase in function names and -calls (I'm
afraid I've done too much Java) - that's me being overly picky.
Lastly, perhaps an svg.info file (or svg.txt or svg.html) could be handy
for the /doc subdir to explain a bit about usage etc. But admittedly
that is a long shot.
Hmmm... perhaps the image pkg maintainer is less picky. Carnë?
Philip
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
