(OctDv list added - pls do reply all)
Nit Nit wrote:
> Hi Philip
>
> OK, I will adapt future binaries respectively after you will finalize
> and release the package to OF.
>
> A suggestion regarding the java jars directory - may be you can consider
> getting the directory name from an environment var (i.e. OCTAVEJAVADIR),
> the env. var can be set by octaverc and read by PKG_ADD
> or by chk_spreadsheet_support.m. This will give some flexibility to
> installation packagers in relation to simple hard-coding
> as /<libdir>/java/. You can always use hard-coded /<libdir>/java/ as a
> default in case the env. var is not set.
(FYI: until now I've deliberately avoided using PKG_ADD and PKG_DEL just
to steer clear from any hard-coded stuff. But your work made me change
my mind a bit.)
OK:
If chk_spreadsheet_support cannot find anything in /<libdir>/java, no
harm is done. So that's the default option already.
There's nothing to stop anyone from having the jars elsewhere and
calling chk_spreadsheet_support or javaaddpath using getenv() to fill in
another java class dir name instead. Where that is implemented does not
matter much.
Do you have a suggestion?
Perhaps:
javadir = getenv ("OCTAVE_JAVA_DIR");
if (isempty (javadir))
javadir = [octave_config_info("libdir") "/java"];
endif
call chk_spreadsheet_support (javadir, 0);
?
PKG_DEL can be left empty anyway, as outlined in my previous mail.
BTW my idea about where class libs should live is based upon what I find
in Matlab, where all java classes reside in (merely) one dir; and on
many Linux distros where generally used java classes are simply put in
/usr/lib.
Philip
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
