On Sun, Nov 27, 2011 at 02:54:24PM -0500, Nir Krakauer wrote: > Dear Olaf, > > Thank you for your suggestions. > > > - Why is 'h' randomized? Even if there should be a good reason, I think this > > cannot be done inside 'line_min'. Rather, make 'h' configurable so that > > users > > can randomize it 'from outside'. > > Since h is currently set arbitrarily, I have found for my applications > that randomizing it somewhat is helpful in optimization (where > line_min is typically called repeatedly), because it is always > possible that for a particular function the hard-coded value will not > lead to downhill movement. > > Another possible fix would be, as you say, to make the step size h > configurable. I added the ability for users to provide h as an input. > > > - Are you sure you don't break someones code by limiting number of > > evaluations > > to 30? Shouldn't this rather be made configurable, too? > > I added the maximum number of evaluations as another optional input. > > > - I think you should only list those changes in the comments which actually > > are made to the code in SVN now. > > I fixed the description of my changes. The diff file shows the changes > in my version from the current SVN version. > > > - Minor issue: The preferred style of Octave is leaving a space between > > fuction name and parantheses (e.g. sum ()) (you have deleted the space at > > some point(s)). > > Modified accordingly. > > Best, > > Nir
Nir, I have commited it with slight modifications. And I removed randomization of h. As I said, this can't be done inside line_min. Users don't expect randomization within a supposedly deterministic optimization function. It will be easy for you to do the randomization in an outside loop and call line_min with the already randomized value. In the future, it would be better to submit context diffs. You can just use 'svn diff <filename>'. And please make the diff against the current version, it was not so now. Thanks, Olaf ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
