On 02/03/2012 08:31 PM, Carnë Draug wrote:
> Hi Moreno
>
> I have just give you write access to the repository. I didn't look
> into the package with much attention but here's some notes that you
> may find useful:

Hello Carnë,

thank you very much for your suggestions. I have committed changes to 
apply all of them, and regenerated the tarball accordingly.

> * packages can be installed with pkg install -forge which means that
> users wil never see the acutal .tar.gz file. After installation, the
> README file will be discarded which means it will never be read. You
> may want to move it into the doc/ section.

Done.

> * you may want to add a NEWS file to the package although right now it
> will probably only say "first release of the package". The file is
> treated secially in new octave versions.

Done.

> * should the broken/ be on the package? Can be on the repository, but
> I don't see why it should be on the package for installation.
> Specially because it won't be installed anyway since pkg will discard
> it (same applies for examples/, scripts/ and test/).

You are right; the directories above are only used to build the 
documentation and run the automated test scripts (which users don't 
normally do), so I removed all of them from the tarball. I also renamed 
"broken/" to "devel/" in the subversion repository (the control package 
has a "devel/" subdirectory as well, which sounds much better than one 
named "broken").

> * why the DESCRIPTION.in file? I believe it was a mistake

Yes, sorry. I have removed it from the tarball.

> * could you move the demos on examples/ as %!demo section at the end
> of the respective function files? I saw the functions already have
> this section so you are aware of them. Why did you have some of them
> separate?

This was a leftover from my build (I removed them from subversion as 
well). These files were automatically extracted from the %!demo blocks 
of the function scripts, so that they could be included in the pdf 
manual (like Octave does).

> Also, the package is on the repository but no release has been made
> yet. You'll need to upload documentation generated after installing
> your package. It's explained in the website but there's also a script
> on the admin section of the repository that tries to do it
> automatically.

Thanks, I will now follow the instructions to make the first release (if 
you want to see if the tarball is ok, I have put the new version here:

http://www.moreno.marzolla.name/software/queueing/queueing-1.0.0.tar.gz

).

Moreno.

-- 
Moreno Marzolla
EMail: mor...@moreno.marzolla.name
WWW  : http://www.moreno.marzolla.name/

------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to