On 20 April 2012 05:56, Daniel Ward <dwa...@gmail.com> wrote: > I have attacked the patch. > > This will expand the returned items to closer match the Matlab kmeans. It > will also add the 'emptyaction' property with the 'singleton' value. This > will allow for the kmeans algorithm to handle empty cluster better. It also > now throws an error if the user does not request and empty cluster handling, > and there is an empty cluster.
Hi Daniel, Sorry for the very late reply. The patch you sent was against the file in the package, not the one on svn but the difference was minimal, just on the copyright notice. I have applied your patch and then made the following changes: * replace tabs per spaces * use octave's rows function rather than size * on the subfunction, I do not created an extra var just to return the value calculate, I return it directly * a few changes of style to be more consistent with octave core (mainly spaces after function calls and not before index and use of double quotes for strings) If you are looking into this function, could you supply a patch for the documentation documentation. There was nothing before but I have just added a block with a one sentence and a @seealso in texinfo. It could however be greatly improved, specially with a list of possible options. Carnë ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
