On 19 April 2012 10:24, Markus Bergholz <marku...@gmail.com> wrote: > 2012/4/18 Markus Bergholz <marku...@gmail.com>: >>> I believe this function would fit better in the miscellaneous package >>> (and can you take a look at csv2latex and maybe publish on that >>> package?). >> >> Oh, i didn't know that those package exist. >> As far as i see it is similar as mine, only by going through a CSV >> file, but with optionaly horizontal/vertical lines and optionaly >> row/column titles. >> >> >>> Also, you don't have a copyright notice on that function so we can't >>> add it to Octave-Forge until then. I'd suggest GPLv3+ (that's the >>> license octave itself and most code in octave-forge uses). >> >> I don't care about the licence. So GPLv3+ is fine too. >> >>> Quite a few different versions of this function have already been proposed, >>> see for example this thread: >>> >>> http://octave.1599824.n4.nabble.com/Creating-Pretty-Report-from-Octave-tp2245980p2245980.html >>> >>> Maybe you could help by merging the features of all variants into one? >> >> I'll take a look and see what my lousy octave skills can do :) >> >> >> greetings >> markus > > First i've change the name from matrix2textable to texwrite. > Than I've include the features of the csv2tex (switching rows lines > on/off, column on/off, alignment set to left/right/center). But i've > don't include the rows/column titles/naming. I don't know if it is > needed and don't know how to handle it. > Then i've added a display in matrix feature. > I've added the code and an example pdf, how does it all look like, but > i don't know how smooth the code is. > > greetings > markus
Hi Markus sorry for the very late reply. I have rewrote the documentation of the function so as to use texinfo properly. I have also renamed textable. I have made a few changes, specially with the input handling, how the defaults are set up and a very minimum input checking and then comitted it. Please see http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/miscellaneous/inst/textable.m Note how the defaults are set up at the top with the line: function textable (data, filename, rlines = 1, clines = 1, alignment = "r", matrixformat = 0) endfunction I also didn't quite understand the sprintf('r') lines, there's no need for that, you can assign the character directly to variable. And why not having the user entering the actual character rather than a number? It will make it easier to remember the API and what value means. And the last input argument, that overwrites all the ones before, what's its use? I don't understand it. Do you think any of this should be changed? Carnë ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
