On Thu, Apr 26, 2012 at 06:09:27PM +0100, Carnë Draug wrote:
> On 26 April 2012 17:49, Mike Miller <mtmil...@ieee.org> wrote:
> > 2012/4/26 Carnë Draug <carandraug+...@gmail.com>:
> >> On 26 April 2012 13:00, Mike Miller <mtmil...@ieee.org> wrote:
> >>> I've noticed a fair number of Makefiles that call mkoctfile instead of
> >>> the $(MKOCTFILE) variable, this will not work as intended if compiling
> >>> against an Octave in a non-standard path, right? Is this something
> >>> that should be fixed per-package or across the board? For example,
> >>> I'm working in comm, should I just submit a patch for comm's Makefile
> >>> for now? Thanks.
> >>
> >> So all Makefile should use?
> >>
> >> ifndef MKOCTFILE
> >> MKOCTFILE := mkoctfile -Wall
> >> endif
> >>
> >> Is this correct? I'll guess that almost all packages will need this fix.
> >
> > Good point. True, I was a bit narrow in scope looking at comm because
> > it has a configure script and already has a MKOCTFILE variable
> > defined, oops :) I think I can patch that one as it is today, problem
> > solved, patch forthcoming later.
So here's the patch for comm's Makefile, takes care of that package at
least. Tested build from shell and within Octave.
--
mike
Index: main/comm/src/Makefile
===================================================================
--- main/comm/src/Makefile (revision 10331)
+++ main/comm/src/Makefile (working copy)
@@ -1,6 +1,6 @@
sinclude Makeconf
-HDF5_LIBS := $(shell grep "\#define OCTAVE_CONF_HDF5_LIBS" $(shell mkoctfile -p OCTINCLUDEDIR)/oct-conf.h | sed "s/^.*LIBS //" )
+HDF5_LIBS := $(shell grep "\#define OCTAVE_CONF_HDF5_LIBS" $(shell $(MKOCTFILE) -p OCTINCLUDEDIR)/oct-conf.h | sed "s/^.*LIBS //" )
GALOISTARGET = gf.oct
GALOISSOURCES = galois.cc galois-def.cc galoisfield.cc gf.cc \
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev
