On 05/10/2012 01:12 AM, Mike Gross wrote: > I had been using my local copy of the blackmanharris function and didn't > realize that my patch was not applied. > > I think that the root issue is that the previous implementer of some or > all of the window functions assumed that the periodic output was the > correct behavior. My bias is to match MatLab behavior which I assume > produces symmetric coefficients. Has this been verified? > > My intention had been to ensure that all of the window functions > returned symmetric coefficients and valid values for integer lengths > greater than zero but somewhere along the line it fell off of my radar. > It seems like James, Daniel and Mike are on top of this but I could > easily assist if it seems worthwhile.
OK. I think there is a start on this from Peter: http://www.mail-archive.com/octave-dev@lists.sourceforge.net/msg01576.html that attempts the "periodic" and "symmetric" distinction. I suggest one of us freshen that patch with the current SVN source and attach it to a bug report. Once we agree on the behavior and appearance of welchwin.m then we'll search for several windows of the same nature and do a similar mod. When we're done we'll move the patch with all changes into SVN. I suggest adding some test cases in the script files to verify it is in fact symmetric or period depending on the choice. I demo that plots side by side the spectral characteristics of the two types might be nice. It would help the user understand the difference between the two options. I might be unavailable until early next week. Dan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
