On 24 May 2012, at 17:47, Mike Miller wrote:

> On Thu, May 24, 2012 at 11:35 AM, c. <carlo.defa...@gmail.com> wrote:
>> 
>> On 24 May 2012, at 15:58, Olaf Till wrote:
>> 
>>> If this change should be made for these packages, I'd advice to use
>>> $(shell $(MKOCTFILE) -p ..._LIBS)
>> 
>> I tried this change in odepkg but it does not seem to work,
>> what I get is just the error
>> 
>> make: -p: Command not found
>> 
>> repeated each time the variable $(LAPACK_LIBS) is used.
>> Does anyone know the correct syntax (if any exists) for this type of nested 
>> variable substitution?
> 
> This is the right way to do it.  I made that same change to
> communications a few weeks back and it works for me.  Run "make -p" in
> src to make sure MKOCTFILE is defined?

Mike,
you're right I just had a typo in the definition of MKOCTFILE.

The following change works for me:

Index: Makefile
===================================================================
--- Makefile    (revision 9817)
+++ Makefile    (working copy)
@@ -9,7 +9,9 @@
 
 # MKOCTFILE = $(MKOCTFILE) has already been defined in Makeconf
 # MKMEXFILE = $(MKOCTFILE) --mex
-MKOCTFILE = mkoctfile
+MKOCTFILE ?= mkoctfile
+
+FFLAGS := $(shell $(MKOCTFILE) -p FFLAGS)
 ifeq (gfortran,$(findstring gfortran,$(F77)))
   MKF77FILE = FFLAGS="-fno-automatic $(FFLAGS)" $(MKOCTFILE)
 endif
@@ -20,8 +22,8 @@
   MKF77FILE = FFLAGS="$(FFLAGS)" $(MKOCTFILE)
 endif
 
-LAPACK_LIBS := $(shell mkoctfile -p LAPACK_LIBS)
-FLIBS := $(shell mkoctfile -p FLIBS)
+LAPACK_LIBS := $(shell $(MKOCTFILE) -p BLAS_LIBS) $(shell $(MKOCTFILE) -p 
LAPACK_LIBS)
+FLIBS := $(shell $(MKOCTFILE) -p FLIBS)
 
 EXTERNALDIRS  = hairer cash daskr
 EXTERNALPACKS = $(patsubst %, %.tgz,  $(EXTERNALDIRS))


Any objections to pushing it?
c.



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to