Hi

I was looking at the built-in forums of sourceforge and found the
following reported 2 years ago (these forums have since been hidden
and blocked to prevent posting). Could someone please review the
following?

Thanks in advance,
Carnë

Reported by jmiles1: possible typo in main/signal/inst/fir2.m:

## make sure grid is big enough for the window
if 2*grid_n < n+1, grid_n = 2^nextpow2(n+1); endif

should probably be

## make sure grid is big enough for the window
if grid_n < n+1, grid_n = 2^nextpow2(n+1); endif

Otherwise it looks like there's a range of grid sizes between n/2 and
n that will be smaller than n, and generate an overlapped impulse
response in line 122. Apologies in advance if this was the intent, but
it definitely doesn't jibe with the comment in line 29.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Octave-dev mailing list
Octave-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to