On 07/13/2012 03:33 PM, C.C.Kling wrote: > Hi, > > I just registered as ckling at sourceforge and would like to register as > a octave-forge developer . I would like to submit a bugfix for the > kmeans.m of the statistics package: > > In cases where clusters contain only one element, the mean() function > for calculating the new center of the cluster will not return the true > center, but will return the mean() of all coordinates of the single > cluster element. > > I fixed that issue and would like to submit the changes. > My changes also include the correction of two mistypings, additionally I > renamed the variable index to idx (for not confusing it with the > function index) and I removed the unnecessary check for > length(mean(...)) in the check for empty clusters. [snip] > Cheers, > Christoph
Hi Christoph, Please create a diff file then a bug report as part of the project and attach the diff file to the bug report: http://sourceforge.net/tracker/?group_id=2888&atid=102888 That way your work isn't lost. Sometimes bug fixes get lost on the list. Also consider adding some test cases to the script file to illustrate what the issue is and prevent a similar bug in the future. Thanks, Dan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
