Hi Carnë, Thanks for looking through it.
> the package still has .svnignore files which should not be released. Did > you do svn export to prepare the release as in > http://octave.sourceforge.net/developers.html ? It may be easier to use the > releasePKG function in admin, it makes preparation of new releases much > faster and easier. I followed the instructions in http://octave.sourceforge.net/developers.html , including using svn export. I don't know what needs to be done to suppress .svn* files > Some other notes: > > * could you turn off the autoload of package? We have last week discussed > about removing this option (if not in pkg, at least for forge packages). We > are still making more adjustments but this is likely to be removed. If you > do so, add that line to the NEWS file > * on the NEWS file you mention that the call to mkpp have been fixed. The > NEWS file are for "important user-visible changes". Should this maybe be > replaced by something like "bug fixes in fnder and csape for compatibility > with new octave versions"? > > * since the package dependencies change (and there's even new functions), > should this still be a minor release? I would think that 1.1.0 would be > more approppriate but it's up to you. OK, I've changed these > * does the splines packages is really dependent on octave > 2.9.7? If I > understood correctly, some of the changes is due to changes on the mkpp > API. Doesn't this mean that the new version will not work on older octave > versions? Probably; also, the new functions use features such as automatic broadcasting that aren't available in previous versions. So I changed the dependence to >=3.6 > * I have previously received complains about the license line on the > DESCRIPTION file from downstream maintainers so I fixed this in a way that > makes them happy. When doing this I noticed that the licenses were GPLv2+ > and since it's at our option, I have changed them to GPLv3+. Also, the > copyright on fnder said 2000 but the author said that it was written on > 2001. I fixed te date on the copyright. I have also adjusted the public > domain "license" on fnval to the form expected by octave. > > * I noticed that there were calls to usage which is going to be deprecated > soon. I have just replaced those by calls to print_usage. Also, some > functions have a mix of tabs and spaces for identation. I have replaced > those by spaces. Sounds good > Also, please upload both html and packagae tarball to the same artifact. Do > not open a separate thread for each. I don't see a way to upload multiple files to one topic on the sourceforge site -- perhaps I'm missing something Best, Nir ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
