OpenBSD src changes summary for 2015-10-11 ==========================================
bin/rm bin/sleep bin/stty lib/libc regress/usr.bin sbin/disklabel sbin/fsirand sbin/ncheck_ffs sbin/newfs sbin/ping sbin/scan_ffs share/man sys/dev/pci sys/kern usr.bin/csplit usr.bin/mandoc usr.bin/nc usr.bin/pkg-config usr.bin/pkill usr.bin/sendbug usr.bin/tmux usr.bin/tsort usr.bin/who usr.sbin/apm usr.sbin/apmd usr.sbin/bgpctl usr.sbin/bgpd usr.sbin/installboot usr.sbin/ldapd usr.sbin/lpr usr.sbin/npppd usr.sbin/smtpd usr.sbin/syslogd usr.sbin/tcpdump == bin =============================================================== 01/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/bin rm ~ rm.1 ~ rm.c > Don't allow "rm -rf /" > Patch from Theo Buehler who was inspired by watching Bryan Cantrill > in BSD Now 103. > Minor tweak from me to turn the complained variables into flags instead > of counters. > "i think it's ok" tedu@ > "this isn't 1980 anymore" deraadt@ > ok millert@ (daniel@) sleep ~ sleep.c > Don't return errno from main() > ok beck@ doug@ deraadt@ tedu@ (guenther@) stty ~ stty.c > pledge "stdio tty" works once the kernel allows TIOCGWINSZ. Do the pledge > after TIOCGETD, which the kernel is unlikely to support (does not feel like > a good idea for a program to switch line disc, and therefor not worth > allowing > the program to ask either) (deraadt@) == lib =============================================================== 02/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib libc ~ sys/bind.2 ~ sys/connect.2 > Document that bind(2) and connect(2) ignore the incoming sa_len > suggest by and ok deraadt@ > wordsmithing jmc@ (guenther@) ~ sys/brk.2 ~ sys/sigaction.2 > Prefer .Fa over .Em for struct members > ok jmc@ (guenther@) ~ gen/signal.3 ~ sys/execve.2 ~ sys/sigaction.2 > Document that execve(2) resets SIGCHLD to SIG_DFL > wordsmithing and ok jmc@ (guenther@) ~ gen/ftw.3 > Fix empty .No macros, use .Pf to prefix delimiters to macros. > Based on a patch from guenther@, tweaked by me. > OK jmc@ guenther@ (schwarze@) ~ time/tzset.3 > Do not insert whitespace into syntax displays, it's just confusing, > except at the one place where it is indeed helpful. > Add some missing .Cm macros. > Remove some useless escaping, one needless .Xo, and an empty .No. > Triggered by a much smaller patch from guenther@. > OK jmc@ guenther@ (schwarze@) == regress =========================================================== 03/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/regress usr.bin ~ pkg-config/Makefile > add variation on existing --exists tests; separated by spaces (jasper@) == sbin ============================================================== 04/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin disklabel ~ disklabel.c > If only displaying the disklabel (the normal thing to do against > potentially > unknown disks...), after opening & reading the disklabel, pledge "stdio" > ok doug (deraadt@) fsirand ~ fsirand.c > After the filesystem is opened, pledge "stdio" > ok doug (deraadt@) ncheck_ffs ~ ncheck_ffs.c > Pledge that ncheck_ffs only uses "stdio" after opening the device. > ok deraadt@ (doug@) newfs ~ mkfs.c > Prefer dprintf() over snprintf()+write() > ok beck@ deraadt@ (guenther@) ping ~ ping.c > Prefer dprintf() over snprintf()+write() > ok beck@ deraadt@ (guenther@) scan_ffs ~ scan_ffs.c > After the disk is opened, this can pledge "stdio". > ok doug (deraadt@) == share ============================================================= 05/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share man ~ man4/acpicpu.4 > vi (guenther@) ~ man4/acpicpu.4 > Use correct terminology (guenther@) ~ man7/mdoc.7 > Mention that the first argument of .Pf does not need escaping. > While here, make the first sentence regarding .Pf more concise. > OK jmc@ (schwarze@) == sys =============================================================== 06/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys dev/pci ~ if_iwm.c ~ if_iwmvar.h > Add a symbolic name for the special '-1' value of iwm's sc_wantresp. > ok phessler (stsp@) kern ~ kern_event.c > Always set the timeout at least one tick in the future for EVFILT_TIMER > to avoid looping in softclock() > based on diff by sthen@ > ok sthen@ (guenther@) ~ kern_pledge.c > __get_tcb() is needed for errno access in threaded programs on some archs. > Make it always available. > ok deraadt@ (guenther@) ~ kern_pledge.c > In pledge "tty", allow TIOCSWINSZ. stty(1) is the obvious silly use. > The more important use will be tmux(1) and other active window size > controlling programs. There seems little risk in exposing this small > tty setting alongside the tcsetattr() family. > ok millert (deraadt@) ~ kern_pledge.c > put TIOCSWINSZ in the right block "tty", not in "ioctl". this happened > because the "route' tests were placed between the two, creating > confusion. fix that while here. (deraadt@) ~ kern_pledge.c > sigaltstack is directly used by setjmp on some architectures. it only > refers to the process itself. pledge should allow it. (deraadt@) ~ kern_pledge.c > add a missed check for PLEDGE_RPATH when reading a file. > ok deraadt@ (semarie@) ~ sys_generic.c > pledge_ioctl_check() will do the killing if neccessary; if it returns, > that is an errno to pass up to the calling system call instead. test > case is "who < /dev/null", via ttyname(). (deraadt@) == usr.bin =========================================================== 07/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin csplit ~ csplit.c > with the RPATH enforcement, csplit(1) don't work anymore on stdin... > the newfile() function used for create files open files in "w+" > (O_RDWR), and may occasionally do reading on the file (function > toomuch()). > ok deraadt@ (semarie@) mandoc ~ main.c ~ mandoc_aux.c ~ mandocdb.c ~ manpath.c ~ mansearch.c ~ read.c ~ term_ps.c > Finally use __progname, err(3) and warn(3). > That's more readable and less error-prone than fumbling around > with argv[0], fprintf(3), strerror(3), perror(3), and exit(3). > It also shortens the code by 50 lines. > It's a bad idea to boycott good interfaces merely because standards > committees ignore them. Instead, it's the job of the portable > distribution to provide compatibility modules for archaic systems > (like commercial Solaris) that still don't have them. Actually, > the compat code for the portable distribution already exists and > will be committed right after this. (schwarze@) ~ tag.c > Drop tags containing a blank character: > They don't work, they break other tags in weird ways, and even > if they could be made to work, they would be mostly useless. > Issue reported by naddy@, thanks. (schwarze@) nc ~ netcat.c > Userspace doesn't need to use SUN_LEN(): connect() and bind() must accept > sizeof(struct sockaddr_un), so do the simple, portable thing > ok beck@ deraadt@ (guenther@) pkg-config ~ pkg-config > handle comma separated list of arguments, i.e. pkg-config --exists > gcr-3,gcr-base-3 (jasper@) pkill ~ pkill.c > fix a regression spotted by chris@. the -f and -I arguments fetch process > arguments using kvm_getargs, after the pledge() has been made. someone > brave should refactor this, hoisting the argument fetching to between > kvm_getprocs() and pledge() - storing the argument data as neccessary. > the current situation is also a race -- it fetches the data twice. > (deraadt@) sendbug ~ sendbug.1 ~ sendbug.c > -version options on commands like this make no sense; the version number > makes no promises about compatibility nor the lack of compatibility. > suggestion & diff from micheal reed (deraadt@) tmux ~ client.c ~ server.c > Userspace doesn't need to use SUN_LEN(): connect() and bind() must accept > sizeof(struct sockaddr_un), so do the simple, portable thing > ok beck@ deraadt@ (guenther@) tsort ~ tsort.c > reorg code to have an array with all the files used apparent. > okay millert@ (espie@) ~ tsort.c > now that tsort has a clean structure, do more specific pledge() calls. > okay deraadt@ (espie@) who ~ who.c > fix regression: ttyname() failure not handled right (deraadt@) == usr.sbin ========================================================== 08/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin apm ~ apm.c > Userspace doesn't need to use SUN_LEN(): connect() and bind() must accept > sizeof(struct sockaddr_un), so do the simple, portable thing. > Also convert some strncpy() to strlcpy() > ok deraadt@ (guenther@) apmd ~ apmd.c > Userspace doesn't need to use SUN_LEN(): connect() and bind() must accept > sizeof(struct sockaddr_un), so do the simple, portable thing. > Also convert some strncpy() to strlcpy() > ok deraadt@ (guenther@) bgpctl ~ bgpctl.8 ~ parser.c > add "best" as an alias for "selected" > Helps finger memory for people used to Junipers > OK benno@, claudio@ (phessler@) ~ bgpctl.c ~ parser.c > Handle the blackhole well-known community in bgpctl as well (print it > symbolically, and don't deny its use in 'bgpctl sh rib comm 65535:6666'). > ok phessler@ (sthen@) bgpd ~ log.h ~ session.h > some peers are following an expired draft RFC and are sending "unknown" > error codes to OPEN messages. make them "known", and show them. > OK benno@, claudio@, sthen@ (phessler@) ~ bgpd.conf.5 ~ bgpd.h ~ parse.y > standardize a community that has been independently created by nearly > every single AS on the planet: the blackhole > OK benno@, claudio@, sthen@ (phessler@) installboot ~ landisk_installboot.c > needs at least some include love; choosing <stdlib.h> (deraadt@) ldapd ~ syntax.c > The <ctype.h> is*() interfaces expect EOF or an unsigned char; cast to > (unsigned char) as required > found by Michael McConville (mmcconv1 (at) sccs.swarthmore.edu) > w/Coccinelle (guenther@) lpr ~ common_source/startdaemon.c ~ lpd/lpd.c > Userspace doesn't need to use SUN_LEN(): connect() and bind() must accept > sizeof(struct sockaddr_un), so do the simple, portable thing. > Also convert some strncpy() to strlcpy() > ok deraadt@ (guenther@) npppd ~ npppd/parse.y > YYSTYPE.number is int64_t, so format with <inttypes.h>'s PRId64 > ok yasuoka@ (guenther@) ~ npppd/npppd_iface.c ~ npppd/npppd_tun.c ~ npppd/privsep.c ~ npppd/privsep.h ~ pppoe/pppoed.c > Simplify and lock down priv_open(): > * kill the 'mode' argument > * fail if passed any flags other than O_ACCMODE OR O_NONBLOCK > * paranoia: mask O_CREAT when calling open() with only two arguments > * instead of using ioctl(FIONBIO) after the fact, pass O_NONBLOCK to > priv_open() > "good start" deraadt@ > ok yasuoka@ (guenther@) smtpd ~ mda.c > Convert some fgetln to getline. > Suggestion and ok millert@, ok gilles@, eric@ (sunil@) ~ table_ldap.c ~ table_passwd.c ~ table_sqlite.c ~ table_static.c > Convert some fgetln to getline. > Ok gilles@, giovanni@, millert@ (sunil@) syslogd ~ syslogd.c > Userspace doesn't need to use SUN_LEN(): connect() and bind() must accept > sizeof(struct sockaddr_un), so do the simple, portable thing. > Also convert some strncpy() to strlcpy() > ok deraadt@ (guenther@) ~ syslogd.c > Pass unsigned char to isdigit(3). > From Michael McConville; OK guenther@ (bluhm@) tcpdump ~ print-ipsec.c > The <ctype.h> is*() interfaces expect EOF or an unsigned char; cast to > (unsigned char) as required > found by Michael McConville (mmcconv1 (at) sccs.swarthmore.edu) > w/Coccinelle (guenther@) =============================================================================== _______________________________________________ odc mailing list [email protected] http://www.squish.net/mailman/listinfo/odc
