OpenBSD src changes summary for 2016-01-04 ==========================================
games/factor games/fish games/fortune games/gomoku games/grdc games/hangman games/morse games/number games/pig games/pom games/ppt games/primes games/quiz games/rain games/random games/robots games/snake games/tetris games/worm games/worms games/wump lib/libc lib/libcrypto libexec/spamd-setup share/man sys/arch/amd64/amd64 sys/arch/amd64/include sys/arch/amd64/stand/libsa sys/dev/ic sys/dev/pci sys/dev/pv sys/net80211 usr.bin/jot usr.bin/lam usr.bin/make usr.bin/mandoc usr.bin/nc usr.bin/patch usr.bin/rs usr.sbin/ftp-proxy usr.sbin/smtpd usr.sbin/vmd == games ============================================================= 01/07 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/games factor ~ factor.c > More headers removal and sorted the remaining alphabetically. > Most noticeable that were removed are sys/types.h which will be included > from > stdlib.h and in turn also brings along sys/cdefs.h. The other one is > limits.h > that was used with the old idiom (denom * random() / LONG_MAX), although it > was > only removed were applicable (some files still need that header). > OK tb@ (mestre@) fish ~ fish.c > More headers removal and sorted the remaining alphabetically. > Most noticeable that were removed are sys/types.h which will be included > from > stdlib.h and in turn also brings along sys/cdefs.h. The other one is > limits.h > that was used with the old idiom (denom * random() / LONG_MAX), although it > was > only removed were applicable (some files still need that header). > OK tb@ (mestre@) fortune ~ fortune/fortune.c ~ strfile/strfile.c ~ unstr/unstr.c > More headers removal and sorted the remaining alphabetically. > Most noticeable that were removed are sys/types.h which will be included > from > stdlib.h and in turn also brings along sys/cdefs.h. The other one is > limits.h > that was used with the old idiom (denom * random() / LONG_MAX), although it > was > only removed were applicable (some files still need that header). > OK tb@ (mestre@) gomoku ~ bdinit.c ~ bdisp.c ~ gomoku.h ~ pickmove.c ~ stoc.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) grdc ~ grdc.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) hangman ~ endgame.c ~ getguess.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) morse ~ morse.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) number ~ number.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) pig ~ pig.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) pom ~ pom.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) ppt ~ ppt.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) primes ~ pr_tbl.c ~ primes.c > More headers removal and sorted the remaining alphabetically. > Most noticeable that were removed are sys/types.h which will be included > from > stdlib.h and in turn also brings along sys/cdefs.h. The other one is > limits.h > that was used with the old idiom (denom * random() / LONG_MAX), although it > was > only removed were applicable (some files still need that header). > OK tb@ (mestre@) quiz ~ quiz.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) rain ~ rain.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) random ~ random.c > More headers removal and sorted the remaining alphabetically. > Most noticeable that were removed are sys/types.h which will be included > from > stdlib.h and in turn also brings along sys/cdefs.h. The other one is > limits.h > that was used with the old idiom (denom * random() / LONG_MAX), although it > was > only removed were applicable (some files still need that header). > OK tb@ (mestre@) robots ~ extern.c ~ init_field.c ~ main.c ~ make_level.c ~ move.c ~ move_robs.c ~ play_level.c ~ query.c ~ rnd_pos.c ~ robots.h ~ score.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) snake ~ snake.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) tetris ~ input.c ~ scores.c ~ screen.c ~ shapes.c ~ tetris.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) worm ~ worm.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) worms ~ worms.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) wump ~ wump.c > More cleanup and sorting on header section > OK tb@ and he also pointed out that for consistency with rest of the tree > we > should include termios.h instead of sys/ttydefaults.h, where applicable > (mestre@) == lib =============================================================== 02/07 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib libc ~ stdio/vfprintf.c > Fix lots of bugs. > 1. When fprintf(fp, "...%ls...", ...) encounters an encoding error, > do not destroy all the fp->_flags, which made the file permanently > unreadable and unwriteable. > 2. Do not change fp->_flags at all in case of encoding errors. > Neither the manual nor POSIX ask for it, no other conversions set the > error indicator, and it isn't needed because the return value reports > failure and must be checked anyway. > 3. Detect failure in mbrtowc(3), do not silently treat invalid bytes > in the format string as the end of the format string. > 4. Detect failure of __find_arguments(), no matter whether due to > out of memory conditions or encoding errors, and gracefully fail > rather than accessing an invalid pointer. > 5. Remove the pointless and slightly dangerous errno = EILSEQ overrides > after functions that already do that and are required by the standard > to do so. > OK jca@ on items 1, 2, and 5. > OK millert@ on the complete diff. > "Completely brutal mix of bugs." deraadt@ (schwarze@) ~ stdio/fgetws.c > Bugfix: When errno happens to be EILSEQ upon entry to fgetws(3), > and when the file ends without a terminating L'\n' character, > fgetws(3) discarded any characters read and reported bogus EOF. > Never export errno(2) unless right after an error occurred! > OK millert@ (schwarze@) ~ stdlib/getopt.3 ~ stdlib/getopt_long.3 > Follow style(9) and drop lint /* NOTREACHED */ annotations from > the examples. > Diff from Juuso Lapinlampi < wub () partyvan ! eu >, thanks! > ok schwarze@ (tb@) libcrypto ~ crypto/arc4random_linux.h > Calling clone(2) with CLONE_NEWPID yields multiple processes with pid=1. > Work around this particular case by reseeding whenever pid=1, but as > guenther@ > notes, directly calling clone(2), and then forking to match another pid, > provides other ways to bypass new process detection on Linux. > Hopefully at some point Linux implements something like MAP_INHERIT_ZERO, > and > does not invent a corresponding mechanism to subvert it. > Noted by Sebastian Krahmer and the opmsg team. > See http://stealth.openwall.net/crypto/randup.c for a test program. > ok beck@ (bcook@) == libexec =========================================================== 03/07 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/libexec spamd-setup ~ spamd-setup.c > pledge(2) spamd-setup(8) > It needs these annotations, to at least run the operations next to them: > stdio: malloc(3) > rpath: open(2) > inet: connect(2)/socket(2) > proc: fork(2) > exec: execvp(3) > While here remove netinet/in.h since all we need is already in arpa/inet.h > and > sort the headers alphabetically > OK beck@ (mestre@) == share ============================================================= 04/07 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share man ~ man4/iwn.4 > adjust CAVEATS for 802.11n; ok stsp (jmc@) == sys =============================================================== 05/07 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys arch/amd64/amd64 ~ locore.S > wrap a long line (mlarkin@) ~ vmm.c > Do proper termination of VMs by doing proper VCPU run state management. > This should fix some of the odd termination errors people have been seeing > (vmctl status showing running VMs after they have exited/crashed, and > invalid instruction panics on vmptrld during certain races) > This diff also implements dropping the biglock when running a VCPU, and > reacquiring the lock as needed based on the type of exit (normal vs. > external interrupt) > diff supplied by Stefan Kempf <sn.kempf at t-online.de>, many thanks! > (mlarkin@) arch/amd64/include ~ vmmvar.h > Do proper termination of VMs by doing proper VCPU run state management. > This should fix some of the odd termination errors people have been seeing > (vmctl status showing running VMs after they have exited/crashed, and > invalid instruction panics on vmptrld during certain races) > This diff also implements dropping the biglock when running a VCPU, and > reacquiring the lock as needed based on the type of exit (normal vs. > external interrupt) > diff supplied by Stefan Kempf <sn.kempf at t-online.de>, many thanks! > (mlarkin@) arch/amd64/stand/libsa ~ softraid.c > Remove parameter name from gpt_chk_mbr() prototype and add prototype > for findopenbsd_gpt(). (krw@) dev/ic ~ re.c > mark the driver MPSAFE. most of this is cleaning up the oactive handling. > if there's lingering bugs we'll deal with them in tree. > ok jmatthew@ (dlg@) dev/pci ~ if_iwn.c ~ if_iwnreg.h ~ if_iwnvar.h > Add initial support for 11n mode to the iwn(4) driver. > Only MCS 0 to 7 are supported for now. > Tested by many. There might still be outstanding issues but they now appear > to be rare. I'm putting this in so that additional fixes can be developed > and tested more easily if required. This diff is already quite large for > one commit. > ok deraadt (stsp@) ~ if_vmx.c > Record the modified mbuf chain after transmit checksum setup code > Keep the modified chain pointer and pass it back to the calling code > so that it will get properly accounted for. Change it to m_pullup > since m_pulldown with a zero offset is just as good. > Tested by yasuoka@, myself and mxb at alumni ! chalmers ! se, thanks! > ok yasuoka, mpi (mikeb@) dev/pv ~ xen.c ~ xenvar.h > Preallocate Grant Table frames to simplify the code for now (mikeb@) ~ xenstore.c > Include the node name into the error message (mikeb@) ~ xen.c > Skip "suspend" device node during probing (mikeb@) net80211 ~ ieee80211.c > Skip over 11n mode during scanning to avoid scanning channels more than > once. > ok sthen jasper kettenis deraadt mpi (stsp@) ~ ieee80211_input.c ~ ieee80211_node.c > While configuring ERP we need to know if we're in 11a or 11g mode so only > configure ERP once we are sure about our operation mode against the AP. > ok sthen jasper kettenis deraadt mpi (stsp@) ~ ieee80211.c ~ ieee80211_input.c ~ ieee80211_proto.c > Don't return 11n mode from ieee80211_chan2mode() so we can switch into > 11a and 11b/g mode correctly when the driver supports 11n. > And make sure the result of this funtion is only used to index > ic_sup_rates. > Its stated purpose is to help select a legacy rate. > ok sthen jasper kettenis deraadt mpi (stsp@) ~ ieee80211_ioctl.c > Fix manual scan while associated in 11a mode. It would only show APs on > 5GHz. > Problem found by benno@ > ok benno@ kettenis@ (stsp@) ~ ieee80211.h ~ ieee80211_input.c ~ ieee80211_output.c > ADDBA frames have a parameter set which we check against our own > capabilities > but we were checking bits in these parameters with the wrong set of > bitmasks. > Negotiating A-MPDUs with some APs failed because of this bug. > ok kettenis@ (stsp@) ~ ieee80211_output.c > Fix another case where the return value of ieee80211_chan2mode() was > used for indexing something other than ic_sup_rates. Should have been > part of earlier commit. (stsp@) ~ ieee80211_input.c > Replace magic shifts and bitmasks used for ADDBA parameters > with proper names, now that we have the corresponding macros. (stsp@) == usr.bin =========================================================== 06/07 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin jot ~ jot.1 > Add HISTORY and AUTHORS sections. > From the author John A. Kunze > via https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196786 > and Michal Mazurek <akfaew at jasminek dot net>. > Correctness also verified from the CSRG archive CD. (schwarze@) lam ~ lam.1 > Add HISTORY and AUTHORS sections. > From the author John A. Kunze > via https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196786 > and Michal Mazurek <akfaew at jasminek dot net>. > Correctness also verified from the CSRG archive CD. (schwarze@) make ~ main.c > Use err(3) instead of various handrolled combinations of perror(3) and > fprintf(stderr, ...) with strerror(3) and exit(3). Make sure the exit > status is 2 if an error occurred. Prompted by gsoares@'s and jsg@'s > audit of exit statuses after failure of pledge(2). > ok gsoares@ (tb@) mandoc ~ mandocdb.c > Improve handling of .Va and .Vt macros. > tedu@ noticed that no Vt= database entries were generated. > Serguey Parkhomovsky suggested the deletion of parse_mdoc_body(). > tb@ noticed that the fix requires more than just adding TYPE_Vt > to the MDOC_Vt mask in the mdoc_handler array. (schwarze@) nc ~ netcat.c > Use the correct values for TLS certificate / private key flags. > fix from Andreas Bartelt <obsd at bartula.de> (bcook@) patch ~ patch.c > usage() should exit 2 here, not EXIT_SUCCESS > ok tb@ (gsoares@) rs ~ rs.1 > Add HISTORY and AUTHORS sections. > From the author John A. Kunze > via https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196786 > and Michal Mazurek <akfaew at jasminek dot net>. > Correctness also verified from the CSRG archive CD. (schwarze@) == usr.sbin ========================================================== 07/07 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin ftp-proxy ~ ftp-proxy.8 > no need for af on divert-to rule; from/ok mikeb (jmc@) smtpd ~ parse.y ~ smtpd.c ~ smtpd.h ~ table.c > switch to /usr/local/libexec when looking for -extras and drop loop > iterating > paths > this effectively reverts table.c r1.21 which was mainly introduced for a > smooth > transition in -current > ok gilles (jung@) ~ lka.c > add proc and exec to pledge in lka, required to run external add-ons > outside of > the daemon memory space, makes -extras tables work again > reported by Tim van der Molen on [email protected] > verified together with sunil > ok gilles (jung@) vmd ~ pci.c ~ virtio.c ~ vmm.c > bzero -> memset for consistency (mlarkin@) ~ vmm.c > Use an bitmap of handler function pointers to track I/O device to handler > function mappings. First step in reworking device support in vmd to better > handle interrupts. (mlarkin@) =============================================================================== _______________________________________________ odc mailing list [email protected] http://www.squish.net/mailman/listinfo/odc
