OpenBSD src changes summary for 2016-03-20 ==========================================
bin/csh bin/ksh distrib/sets etc/mtree/BSD.x11.dist include/tib.h lib/csu lib/libc lib/libedit lib/libevent lib/libexpat lib/librthread lib/libssl libexec/ld.so regress/lib regress/libexec share/locale sys/dev/usb sys/kern sys/lib/libkern sys/netinet6 usr.bin/head usr.bin/locale usr.bin/mandoc usr.sbin/iscsid usr.sbin/ldapd == bin =============================================================== 01/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/bin csh ~ lex.c > Use fcntl(fd, F_SETFL, flags) to clear O_NONBLOCK instead of > ioctl(fd, FIONBIO, ...). OK krw@ (millert@) ksh ~ io.c ~ misc.c ~ shf.c > Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0]) > idioms. > Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0) > where it is obvious further investigation will not yield and > even better way. > Obviousness evaluation and ok guenther@ (krw@) == distrib =========================================================== 02/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/distrib sets ~ lists/base/md.alpha ~ lists/base/md.amd64 ~ lists/base/md.armish ~ lists/base/md.armv7 ~ lists/base/md.hppa ~ lists/base/md.hppa64 ~ lists/base/md.i386 ~ lists/base/md.landisk ~ lists/base/md.loongson ~ lists/base/md.luna88k ~ lists/base/md.macppc ~ lists/base/md.octeon ~ lists/base/md.sgi ~ lists/base/md.socppc ~ lists/base/md.sparc ~ lists/base/md.sparc64 ~ lists/base/md.zaurus > sync (deraadt@) ~ lists/base/mi > sync (deraadt@) == etc =============================================================== 03/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/etc mtree/BSD.x11.dist ~ mtree/BSD.x11.dist > add include directories used by recent versions of libdrm (jsg@) == include =========================================================== 04/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/include tib.h ~ tib.h > Prepare for future ld.so/libc bump: update <tib.h> with the definitions > that will be needed and make libpthread work when ld.so/libc.a provide an > initial TIB. (guenther@) == lib =============================================================== 05/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib csu ~ crt0.c ~ alpha/md_init.h ~ amd64/md_init.h ~ arm/md_init.h ~ hppa/md_init.h ~ hppa64/md_init.h ~ i386/md_init.h ~ m88k/md_init.h ~ mips64/md_init.h ~ powerpc/md_init.h ~ sh/md_init.h ~ sparc/md_init.h ~ sparc64/md_init.h > Rearrange C runtime bits: now that ld.so exports environ and __progname, > move their definitions and initialization in static links to libc.a > Make crt0 always invoke a new func _csu_finish() in libc to process the > auxv > and to either register the ld.so cleanup function (in dynamic links) or > initialize environ and __progname and do MC_DISABLE_KBIND (in static > links). > In libc, get pagesize from auxv; cache that between getpagesize() and > sysconf(_SC_PAGESIZE) > ok mpi@ "good time" deraadt@ (guenther@) libc ~ stdio/fdopen.c > Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0]) > idioms. > Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0) > where it is obvious further investigation will not yield and > even better way. > Obviousness evaluation and ok guenther@ (krw@) ~ Symbols.list ~ shlib_version ~ dlfcn/Makefile.inc ~ gen/getpagesize.c ~ gen/sysconf.c ~ hidden/unistd.h + arch/alpha/gdtoa/kbind.h + arch/amd64/gdtoa/kbind.h + arch/arm/gdtoa/kbind.h + arch/hppa/gdtoa/kbind.h + arch/hppa64/gdtoa/kbind.h + arch/i386/gdtoa/kbind.h + arch/m88k/gdtoa/kbind.h + arch/mips64/gdtoa/kbind.h + arch/powerpc/gdtoa/kbind.h + arch/sh/gdtoa/kbind.h + arch/sparc/gdtoa/kbind.h + arch/sparc64/gdtoa/kbind.h + dlfcn/init.c > Rearrange C runtime bits: now that ld.so exports environ and __progname, > move their definitions and initialization in static links to libc.a > Make crt0 always invoke a new func _csu_finish() in libc to process the > auxv > and to either register the ld.so cleanup function (in dynamic links) or > initialize environ and __progname and do MC_DISABLE_KBIND (in static > links). > In libc, get pagesize from auxv; cache that between getpagesize() and > sysconf(_SC_PAGESIZE) > ok mpi@ "good time" deraadt@ (guenther@) ~ dlfcn/init.c > Add line (guenther@) ~ sys/__get_tcb.2 > It's libpthread, not librthread, and __tfork(2) lets you set the TCB > address of the new thread (guenther@) ~ sys/__thrsleep.2 > __thrsleep.2 is contained in section 2 > ok jmc (natano@) ~ locale/Makefile.inc > LOCALE_CHARSETS has been unused for some time now > so no need to include share/locale/ctype/Makefile.inc to get it. > ok guenther@ stsp@ (who had the same diff) (jca@) libedit ~ readline.c > Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0]) > idioms. > Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0) > where it is obvious further investigation will not yield and > even better way. > Obviousness evaluation and ok guenther@ (krw@) ~ chartype.h ~ read.c > Fix the CHARSET_IS_UTF8 case in read_char(). > For now, this mainly help programs explicitly using > wide-character functions like el_wgetc(3) and el_wgets(3). > 1. After reading an invalid byte sequence, do not throw away additional > valid bytes; fix by me using mbrtowc(3), obsoleting utf8_islead(). > 2. When read(2) returns EOF, return that information to the caller, > do not prod on and potentially access garbage data in the buffer; > from Linas Vepstas via NetBSD read.c rev. 1.70 2013/05/27. > 3. After read__fixio() failure, restore errno to the one set by read(); > from Steffen Nurpmeso via NetBSD read.c rev. 1.68 2012/09/10. > 4. After read__fixio() success, restore errno to the initial state > upon function entry; fix by me. > OK czarkoff@. Also committed to NetBSD. (schwarze@) ~ read.c > Fix read_char() for the non-UTF-8 case, in particular for systems > supporting other multibyte locales or having an internal representation > of wchar_t that doesn't match UCS-4. > No functional change on OpenBSD, but it makes the code less confusing. > OK czarkoff@. (schwarze@) ~ chartype.h ~ eln.c > Fix the public interface function el_getc(3). > On OpenBSD, the effects are to set the return argument to the NUL byte > in case of a read failure (for robustness) and to properly set errno > when the character is out of range and cannot be stored in a byte. > Once we enable UTF-8, this will be needed to avoid returning bogus > bytes for valid Unicode characters. > On systems where the internal representation of wchar_t doesn't > match UCS-4, breakage was potentially even worse. > OK czarkoff@. (schwarze@) ~ el.h ~ eln.c ~ read.c > Delete the weird IGNORE_EXTCHARS flag, simplifying the code > in the generic low-level function read_char(). > Until we fully enable UTF-8 support, instead filter out non-ASCII > characters in the more logical place in the high-level function > el_gets(3). > OK czarkoff@. (schwarze@) ~ chartype.c ~ chartype.h ~ read.c > Get rid of "#ifdef WIDECHAR" and one goto in read_char(), > making the code more readable. Instead, provide an mbrtowc(3) > replacement function in chartype.[hc], files that encapsulate > such system dependencies anyway. No functional change. > OK czarkoff@ (schwarze@) ~ chared.c ~ chared.h ~ chartype.h ~ common.c ~ emacs.c ~ keymacro.c ~ makelist ~ map.c ~ parse.c ~ refresh.c ~ refresh.h ~ search.c ~ search.h ~ terminal.c ~ terminal.h ~ tty.c ~ vi.c > Delete the useless Int datatype and always use the standard wint_t > directly. This is not a problem because <wchar_t> is required all > over the place anyway, even when WIDECHAR is not defined. > No functional change except that it fixes a few printf(3) > format string issues, %c vs. %lc. > OK czarkoff@ (schwarze@) ~ tokenizer.c > Fix the same bug again that was already fixed in: > OpenBSD tokenizer.c rev. 1.8 2003/08/11 18:21:40 deraadt > Don't increase amax on realloc() failure. > The original fix got lost in a merge along the way. > This fix from Christos Zoulas via NetBSD tokenizer.c rev. 1.23 2016/02/15. > OK czarkoff@ (schwarze@) ~ sig.c ~ sys.h ~ terminal.c > minor simplifactions, style fixes, and trivial syncs from NetBSD > (schwarze@) ~ config.h ~ el.c ~ history.c ~ sys.h > Use getline(3) rather than fgetln(3) because it is standardized > and simpler and safer to use. Implemented by Christos Zoulas > following my suggestion, with a bug fix by me. (schwarze@) ~ TEST/Makefile > support WIDECHAR; > OK czarkoff@ (schwarze@) ~ chared.c ~ chared.h ~ common.c ~ el.c ~ el.h ~ eln.c ~ emacs.c ~ filecomplete.c ~ hist.h ~ makelist ~ map.c ~ parse.c ~ prompt.h ~ readline.c ~ refresh.h ~ search.c ~ search.h ~ sig.c ~ sig.h ~ terminal.h ~ tty.c ~ tty.h ~ vi.c > Cleanup of private header inclusion: > 1. Do not include private headers from "chared.h", "hist.h", "prompt.h", > "refresh.h", "search.h", "sig.h", "terminal.h", "tty.h". > The only private header having to include other private headers is "el.h". > 2. Do not include "common.h", "parse.h", "help.h" from "el.h", > and do not include "emacs.h" and "vi.h" from "chared.h", > include them directly where needed. > 3. Do include "fcns.h" from "el.h" because el_func_t is needed for "map.h". > 4. Do not include private headers again that are already included by > "el.h". > 5. Include private headers after standard headers. > OK czarkoff@ (schwarze@) ~ common.c ~ el.h > delete useless "typedef int bool_t", use int directly; > OK czarkoff@ (schwarze@) ~ Makefile ~ chared.c ~ chared.h ~ chartype.c ~ chartype.h ~ common.c ~ el.c ~ el.h ~ emacs.c ~ filecomplete.c ~ hist.c ~ hist.h ~ histedit.h ~ history.c ~ keymacro.c ~ makelist ~ map.c ~ parse.c ~ prompt.h ~ read.c ~ read.h ~ readline.c ~ refresh.c ~ search.c ~ sig.c ~ sys.h ~ terminal.c ~ tokenizer.c ~ tty.c ~ vi.c ~ TEST/tc1.c ~ readline/Makefile ~ readline/readline.h > Cleanup of standard header inclusion: > 1. Add the missing <errno.h> to sig.c. > 2. Do not include standard headers from private headers "chared.h" > and "el.h", include them directly where needed. > 3. Delete a few needless inclusions of <ctype.h>. > 4. Sort the standard headers. > 5. Delete _GNU_SOURCE weirdness from histedit.h, that file doesn't even > need the access to wcsdup(3) mentioned in the comment. > 6. Delete some trailing blanks and blanks before tabs. > OK czarkoff@ (schwarze@) libevent ~ evutil.c > Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0]) > idioms. > Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0) > where it is obvious further investigation will not yield and > even better way. > Obviousness evaluation and ok guenther@ (krw@) libexpat ~ doc/reference.html > " the the " -> " the ", or in a couple of cases replace the superfluous > "the" with the obviously intended word. > Started with a "the the" spotted by Mihal Mazurek. (krw@) librthread ~ rthread.c > Prepare for future ld.so/libc bump: update <tib.h> with the definitions > that will be needed and make libpthread work when ld.so/libc.a provide an > initial TIB. (guenther@) libssl ~ src/crypto/des/asm/des_enc.m4 ~ src/crypto/ec/ec_asn1.c ~ src/doc/apps/ca.pod ~ src/doc/apps/dgst.pod ~ src/doc/apps/x509.pod ~ src/ssl/s3_cbc.c > " the the " -> " the ", or in a couple of cases replace the superfluous > "the" with the obviously intended word. > Started with a "the the" spotted by Mihal Mazurek. (krw@) == libexec =========================================================== 06/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/libexec ld.so ~ Symbols.map ~ dlfcn.c ~ library.c ~ library_mquery.c ~ loader.c ~ resolve.c ~ resolve.h ~ util.c ~ alpha/rtld_machine.c ~ m88k/rtld_machine.c ~ mips64/rtld_machine.c ~ powerpc/rtld_machine.c > Export environ and __progname, making the latter a copy of just the > filename > portion like crt0 does. This is prep for eliminating _dl_fixup_user_env() > Mark almost everything in resolve.h as hidden, to improve code generation. > ok kettenis@ mpi@ "good time" deraadt@ (guenther@) == regress =========================================================== 07/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/regress lib ~ libpthread/stdfiles/stdfiles.c > Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0]) > idioms. > Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0) > where it is obvious further investigation will not yield and > even better way. > Obviousness evaluation and ok guenther@ (krw@) ~ libedit/read/Makefile > Fix the CHARSET_IS_UTF8 case in read_char(). > For now, this mainly help programs explicitly using > wide-character functions like el_wgetc(3) and el_wgets(3). > 1. After reading an invalid byte sequence, do not throw away additional > valid bytes; fix by me using mbrtowc(3), obsoleting utf8_islead(). > 2. When read(2) returns EOF, return that information to the caller, > do not prod on and potentially access garbage data in the buffer; > from Linas Vepstas via NetBSD read.c rev. 1.70 2013/05/27. > 3. After read__fixio() failure, restore errno to the one set by read(); > from Steffen Nurpmeso via NetBSD read.c rev. 1.68 2012/09/10. > 4. After read__fixio() success, restore errno to the initial state > upon function entry; fix by me. > OK czarkoff@. Also committed to NetBSD. (schwarze@) libexec ~ ld.so/Makefile + ld.so/init-env/Makefile + ld.so/init-env/libaa/Makefile + ld.so/init-env/libaa/aa.C + ld.so/init-env/libaa/shlib_version + ld.so/init-env/prog/Makefile + ld.so/init-env/prog/prog.c > Add regress for environ and __progname vs load-time .init functions > (guenther@) == share ============================================================= 08/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share locale - ctype/Makefile.inc ~ ctype/Makefile > Kill LOCALECHARSETS machinery, we only support ASCII and UTF-8 LC_CTYPE > Remove Makefile.inc and inline rules to produce LC_CTYPE for UTF-8. > ok guenther@ stsp@ (jca@) == sys =============================================================== 09/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys dev/usb ~ if_axen.c > Update the axen driver to initialize the hardware on reset. Change was > suggested by Takahiro Hayashi. Also lock the mii before performing the > write, based on changes in NetBSD. While in there, remove the decaying > eeprom code that has been commented out. This allows my adapter to attach > reliably, pass traffic, and has not panic'd my machine when I unplug it. > Test feedback and OK stsp@, and OK mpi@ (bmercer@) kern ~ kern_clock.c ~ kern_timeout.c > Update ticks in hardclock(). > OK mikeb@ (uebayasi@) lib/libkern ~ arch/amd64/strlen.S > " the the " -> " the ", or in a couple of cases replace the superfluous > "the" with the obviously intended word. > Started with a "the the" spotted by Mihal Mazurek. (krw@) netinet6 ~ in6_pcb.c ~ udp6_output.c > Revert, missing decl for in6_pcbaddrisavail() breaks kernel build. > Spotted by deraadt@ (jca@) == usr.bin =========================================================== 10/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin head ~ head.c > whitespace: remove a space before a tab and a trailing tab. (tb@) locale ~ Makefile > LOCALE_CHARSETS has been unused for some time now > so no need to include share/locale/ctype/Makefile.inc to get it. > ok guenther@ stsp@ (who had the same diff) (jca@) mandoc ~ term.c > " the the " -> " the ", or in a couple of cases replace the superfluous > "the" with the obviously intended word. > Started with a "the the" spotted by Mihal Mazurek. (krw@) == usr.sbin ========================================================== 11/11 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin iscsid ~ util.c > Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0]) > idioms. > Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0) > where it is obvious further investigation will not yield and > even better way. > Obviousness evaluation and ok guenther@ (krw@) ldapd ~ btree.c > Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0]) > idioms. > Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0) > where it is obvious further investigation will not yield and > even better way. > Obviousness evaluation and ok guenther@ (krw@) =============================================================================== _______________________________________________ odc mailing list [email protected] http://www.squish.net/mailman/listinfo/odc
