OpenBSD src changes summary for 2017-05-28 ==========================================
bin/chmod bin/ksh distrib/miniroot distrib/special etc/netstart etc/rc.d/rc.subr games/robots lib/librthread libexec/getty regress/bin regress/sys sbin/dhclient sbin/pfctl share/man share/misc sys/arch/amd64/amd64 sys/arch/amd64/include sys/arch/i386/conf sys/arch/i386/i386 sys/arch/i386/include sys/arch/mips64/mips64 sys/ddb sys/dev/acpi sys/dev/pci sys/net sys/netinet sys/netinet6 usr.bin/cvs usr.bin/signify usr.bin/tmux usr.sbin/bgpd usr.sbin/httpd usr.sbin/ldapd usr.sbin/relayd usr.sbin/slaacctl usr.sbin/slaacd usr.sbin/smtpd usr.sbin/tcpdump usr.sbin/traceroute usr.sbin/vmd == bin =============================================================== 01/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/bin chmod ~ Makefile ~ chmod.c ~ chown.8 > chown: Remove SUPPORT_DOT ifdef - it's on by default for 22 years > The old syntax was deprecated 25 years ago when the utility was > first standardised in IEEE Std 1003.2-1992 ("POSIX.2"). There was > no POSIX version of chown with the dot separator. > Let's stop pretending that it will ever go away. > OK jung@, deraadt@, jmc@ (awolk@) ksh ~ vi.c > Fix cursor position while removing characters from the command line. > While here, remove a condition that becomes redundant. > ok schwarze@ tb@ (anton@) == distrib =========================================================== 02/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/distrib miniroot ~ install.sub > Remove _mode variable and use AI_MODE directly instead. Use the > exit code of ftp consistently to determine success of fetching the > response file. > discussed with and OK tb@ (rpe@) special ~ signify/Makefile > when copying curvy files from ssh, an extra one snuck in. > signify doesn't do any kex stuff and doesn't need scalarmult. (tedu@) == etc =============================================================== 03/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/etc netstart ~ netstart > etc/netstart: use colon separator instead of dot with chown > OK jung@, deraadt@, jmc@ (awolk@) rc.d/rc.subr ~ rc.d/rc.subr > Drop useless lines continuation; no functional change. (ajacoutot@) ~ rc.d/rc.subr > When a daemon reaches its timeout when starting, display "timeout" instead > of "ok" so the user is warned and has a chance to fix it (most of the time > due to bogus flags). Daemons reaching the timeout without being able to > start are still marked as "failed" (which should also give a clue to the > user that some investigation is needed). > prodded by beck@ a while ago > discussed with and ok sthen@ (ajacoutot@) ~ rc.d/rc.subr > Indent and rename var; no functional change. (ajacoutot@) ~ rc.d/rc.subr > Move check later to mitigate a possible race. (ajacoutot@) == games ============================================================= 04/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/games robots ~ score.c > high scores printed too far to the right, move it left a little (tedu@) ~ main.c > if your dying scream would escape the death field, realign to stay within > (tedu@) ~ robots.6 > there are no bugs; i fixed them (tedu@) ~ rnd_pos.c > remove unused macro (tedu@) ~ robots.6 > remove some escapes that are unnecessary/harmful. ok jmc schwarze (tedu@) == lib =============================================================== 05/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib librthread ~ rthread_mutex.c > Use membar_enter_after_atomic() and membar_exit_before_atomic(). (mpi@) == libexec =========================================================== 06/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/libexec getty ~ main.c > Do a better job of not printing sequences we cannot reverse in DELETE or > KILL. Therefore we can do a better job cleaning up. > testing by benno (deraadt@) == regress =========================================================== 07/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/regress bin ~ ksh/vi/vi.sh > Fix cursor position while removing characters from the command line. > While here, remove a condition that becomes redundant. > ok schwarze@ tb@ (anton@) sys ~ netinet/ipsec/Makefile > Now that pf looks behind IPv4 authentication headers, disable the > transport mode tests that fail because of floating states. At least > IPv4 and IPv6 are in sync now. (bluhm@) == sbin ============================================================== 08/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin dhclient ~ dispatch.c > Elegant and reliable link status checking courtesy of mpi@. > Less of unreliable ioctl(SIOCGIFMEDIA), more getifaddrs(). > ok mpi@ (krw@) pfctl ~ pfctl_osfp.c > print_ioctl() is unused if not debugging. Found with clang, after > marking the function "static". Use OSFP_DEBUG, in a similar > fashion to OPT_DEBUG (pfctl_optimize.c). > OK bluhm@ (akfaew@) ~ parse.y > Don't check np->port for NULL - it's an array, it's never NULL. > OK bluhm@ (akfaew@) == share ============================================================= 09/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share man + man7/airport.7 > document /usr/share/misc/airport contents and rules, after lengthy > hackroom discussion about train stations. > ok mlarkin, feedback deraadt (benno@) ~ man7/Makefile > install new manpage, noted by tb@ (benno@) misc ~ inter.phone > convert to UTF-8 (tedu@) ~ airport > add HWD - Hayward Executive Airport. After extensive discussion, the > decision was made that a missed approach at the DH counts as "being at > the airport" > ok phessler, deraadt (mlarkin@) ~ airport > The High Council of Deciders has determined that railway stations, even > those with IATA codes, are not airports and therefore do not qualify for > inclusion in this file. (tedu@) ~ airport > typo (mlarkin@) - operator ~ Makefile > please read operator(7) for this information. (benno@) ~ airport > Add ZIA, even given that I didn't visit it after it actually became ZIA > instead of Ramenskoe Airfield. > approved by deraadt@ (zhuk@) ~ airport > Add BND, I've been there many times. (ajacoutot@) == sys =============================================================== 10/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys arch/amd64/amd64 ~ lock_machdep.c > Use intr_disable()/intr_restore() to reduce differences with sparc64 > mp_lock. > ok kettenis@, visa@ (mpi@) ~ db_trace.c > If a function is not found in the CTF data, do not assume it takes no > argument. (mpi@) ~ vmm.c > typo in comment (mlarkin@) arch/amd64/include ~ vmmvar.h > rename some fields (mlarkin@) arch/i386/conf ~ Makefile.i386 > Build i386 kernels with -ffreestanding, matching amd64 and various > other platforms. > ok visa@ kettenis@ (jsg@) arch/i386/i386 ~ lock_machdep.c > Use intr_disable()/intr_restore() to reduce differences with sparc64 > mp_lock. > ok kettenis@, visa@ (mpi@) ~ db_trace.c > If a function is not found in the CTF data, do not assume it takes no > argument. (mpi@) arch/i386/include ~ atomic.h > remove bogus atomic_swap_64 code from i386 > xchg can't handle 64 bit values on i386. gcc errors if the code > is called, clang errors if it is included. > ok mlarkin@ kettenis@ (jsg@) arch/mips64/mips64 ~ ipifuncs.c > mips64_multicast_ipi() excludes current CPU. > The caller does not have to do that. (visa@) ~ ipifuncs.c > Use fast path if remote call is not needed. > Note that rendezvous calls are no longer necessarily > serialized systemwide. (visa@) ~ ipifuncs.c > Do not allow NULL callback at rendezvous and clear callback > pointer at the end to catch errors faster. (visa@) ddb ~ db_ctf.c ~ db_elf.c ~ db_elf.h > Merge two functions to lookup ELF sections by name. > ok claudio@, jasper@ (mpi@) ~ db_ctf.c > If a function is not found in the CTF data, do not assume it takes no > argument. (mpi@) dev/acpi ~ dsdt.c > Remove a redundant assignment introduced in revision 1.219 but favor the > assignment outside of the conditional. > ok stsp@ (anton@) dev/pci ~ if_iwm.c ~ if_iwmvar.h > Remove unused flag IWM_FLAG_STOPPED. > ok tedu@ of course (stsp@) ~ if_iwm.c > Fix some spurious fatal firmware errors in iwm(4). > If we are not in SCAN state anymore by the time hardware signals completion > of a scan command, exit the scan completion handler immediately instead of > calling ieee80211_end_scan(). > Tested by tb@ and myself. > ok mpi@ tb@ zhuk@ (stsp@) net ~ if_enc.c > Protect the global array of interfaces with the NET_LOCK(). > ok sashan@ (mpi@) ~ if_trunk.c > Remove useless splnet()/splx() dances. > Data structures modified in the ioctl path are protected by the NET_LOCK(). > ok sashan@ (mpi@) ~ if.c > Leaving IP multicast group requires the NET_LOCK(). > Grab the lock before calling carpdetach(). > ok bluhm@ (mpi@) ~ if.c ~ if_ethersubr.c ~ if_pppx.c ~ netisr.h ~ pipex.c ~ pipex_local.h > Remove all splnet/splx from pipex(4) and pppx(4) and replace some of > them by NET_LOCK/NET_UNLOCK. Also make the timeout for pipex_timer > run with a thread context and replace pipex softintr by NETISR_PIPEX. > ok mpi (yasuoka@) ~ if_trunk.c > trunk_port_destroy() needs the NET_LOCK(). > It brings the interface down and restore the original lladdr. > Found by Hrvoje Popovski (mpi@) ~ pf.c > Pf was handling IPv4 and IPv6 differently regarding AH extension > headers. pf_walk_header6() steps over it and detects the real > protocol. So to implement a minimal header walking function > pf_walk_header() for IPv4. It does the header checks and jumps > over AH. Then pf does not understand AH as a protocol, it is just > an extension that authenticates the packet. Move some header and > option checks to pf_walk_header() for consistency with IPv6. This > also improves the header check for IPv4 packets in ICMP payload. > OK henning@ (bluhm@) ~ if_trunk.c > Add missing NET_UNLOCK() in error path. > Spotted by sashan@ (mpi@) ~ pf.c ~ pfvar.h > Fix bad white spaces, wrap long lines, kill some empty lines. (bluhm@) ~ pf.c > Limit the nested header chain for IPv6 extensions headers and for > authentication headers in the IPv4 case. This prevents spending > excessive cpu time on crafted packets. > OK henning@ (bluhm@) ~ pipex.c > Use interface index instead of ifnet pointer. (yasuoka@) ~ if_pppx.c ~ pipex_local.h > Use interface index and if_{put,get} instead of ifnet pointer. (yasuoka@) ~ pipex.c > Check also whether the interfaces is matched when pipex check PPPoE > packets. This fixes the problem when pipex connects with pppoe(4) > through pair(4). (yasuoka@) ~ pipex.c > Process packets immediately without queuing since pipex is believed MP safe > already, for PPPoE case as first step. > ok mpi (yasuoka@) ~ pipex_local.h > fix broken include on previous pipex commit > ok deraadt (mlarkin@) netinet ~ ip_input.c ~ ip_var.h ~ ipsec_input.c > Rename ip_local() to ip_deliver() and give it the same parameters > as the pr_input functions. Add an assert that IPv4 delivery ends > in IP proto done to assure that IPv4 protocol functions work like > IPv6. > OK mpi@ (bluhm@) ~ ip_input.c > clang warns on unused labels. Place a recently introduced label under > ifdef IPSEC to fix the clang build when IPSEC is not defined. > ok deraadt@ bluhm@ (jsg@) ~ ip_carp.c > Leaving IP multicast group requires the NET_LOCK(). > Grab the lock before calling carpdetach(). > ok bluhm@ (mpi@) ~ ip_ipip.c > Call bpf_mtap_af() a bit earlier in ipip_input(). This prepares > upcoming diffs, no functional change. > OK mpi@ (bluhm@) netinet6 ~ ip6_input.c ~ ip6_var.h > Rename ip_local() to ip_deliver() and give it the same parameters > as the pr_input functions. Add an assert that IPv4 delivery ends > in IP proto done to assure that IPv4 protocol functions work like > IPv6. > OK mpi@ (bluhm@) == usr.bin =========================================================== 11/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin cvs ~ logmsg.c > Bring the opencvs log message template inline with other cvs > implementations. > ok stsp@ (joris@) ~ status.c > Teach opencvs status to display the sticky tag according to what it really > represents if it is a branch or a revision. > ok stsp@ (joris@) ~ commit.c > Don't allow opencvs to commit towards tags that are not branches. > Gets rid of the old logic that wasn't working and replaced it with > a simplified version. > ok stsp@ (joris@) ~ cvs.h ~ file.c ~ import.c > Let opencvs show ignored files on import, not showing them is just > confusing. > ok stsp@ (joris@) signify - smult_curve25519_ref.c ~ Makefile > when copying curvy files from ssh, an extra one snuck in. > signify doesn't do any kex stuff and doesn't need scalarmult. (tedu@) tmux ~ cmd-refresh-client.c > Also recalculate session sizes when refreh-client -C is used. GitHub > issue 947. (nicm@) ~ cmd-new-session.c > Change so that sessions created detached (-d or no client) are always > 80x24 and the status line is not applied until they attach. Also make -x > and -y work for control clients whether the session is detached or not. > (nicm@) ~ input.c > Support OSC 10 and 11 to set foreground and background colours, from > "bertnp" in GitHub issue 942. (nicm@) == usr.sbin ========================================================== 12/12 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin bgpd ~ bgpd.h ~ control.c ~ rde.c ~ rde.h ~ rde_rib.c ~ session.c ~ session.h > Implement an XON/XOFF protocol between the RDE and the SE to throttle > per control session and peer the generation of imsg in the RDE. This > reduces the memory pressure in the SE substantially and also a bit in > the RDE. Makes the RDE more responsive for bgpctl commands. > Tested by me with 100 peers * 2000 prefixes and by phessler@ on an AMS-IX > border router with 200+ session. Convergance time got quite a bit better. > OK phessler@ (claudio@) ~ bgpd.c ~ bgpd.h ~ config.c ~ kroute.c ~ parse.y > so far, bgpd was hardcoded to use rtable 0 for nexthop verification. > instead, use the rtable bgpd was started in (route -T <n> exec / rc.d > daemon_rtable) for nexthop verification and as default Adj-RIB-In and > Loc-RIB. This allows multiple bgpds in different rdomains on the same > machine - bgp router virtualization if you like buzzwords. > initial version written under contract more than a year ago, it took us > a while to wrap our brains around the bgpd <-> rdomain interactions - > 1) RIBs, 2) nexthop verification and 3) tcp sockets. > ok & input phessler claudio benno (henning@) ~ bgpd.conf.5 > we're not hardcoded to table 0 any more (henning@) ~ bgpd.conf.5 > tweak previous; (jmc@) ~ rde.c ~ session.c > Close imsg pipes later in the process. The shutdown code still tires to > send imsgs and so the SE and RDE crashed because of this late in shutdown. > OK benno@ phessler@ (claudio@) ~ bgpd.h ~ logmsg.c > Introduce log_peer_info() and make log_peer_warn() log at LOG_ERR instead > of LOG_CRIT (which should only be used for fatal). > OK benno@ (claudio@) ~ rde.c > Print when we send or recv an EOR marker. > Req by and OK benno@ (claudio@) httpd ~ config.c ~ httpd.c ~ httpd.h ~ proc.c > use __func__ in log messages. > From Hiltjo Posthuma hiltjo -AT codemadness -DOT- org, thanks! > ok florian, claudio (benno@) ldapd ~ syntax.c > Fix checks for seconds and timezones in generalized times. > Fixing the CHECK_RANGE macro in r1.4 revealed that the seconds check > accidentally relied on the macro being broken. While looking into this I > noticed that the timezone check was also wrong, treating the timezone as > optional for generalized times. > investigation and diff mostly by Seiya Kawashima. (jmatthew@) relayd ~ agentx.c ~ ca.c ~ check_icmp.c ~ check_script.c ~ check_tcp.c ~ hce.c ~ pfe.c ~ pfe_filter.c ~ pfe_route.c ~ proc.c ~ relay.c ~ relay_http.c ~ relay_udp.c ~ relayd.c ~ snmp.c ~ ssl.c > use __func__ in log messages. fix some whitespace while here. > From Hiltjo Posthuma hiltjo -AT codemadness -DOT- org, thanks! > ok florian, claudio (benno@) slaacctl ~ slaacctl.c > propose and configure default gateway (florian@) slaacd ~ engine.c ~ engine.h ~ frontend.c ~ slaacd.c ~ slaacd.h > propose and configure default gateway (florian@) ~ engine.c > No need to constantly re-add the default route. It will not expire > like the prefixes. We might want to check if someone deleted the > route by hand though. (florian@) ~ engine.c > get a new privacy address before the old one expires (florian@) ~ engine.c > pasto, typos, spelling; ok florian@ (naddy@) ~ engine.c ~ engine.h ~ slaacd.c > set autoconfprivacy flag; prodding naddy (florian@) ~ engine.c ~ slaacd.c > removed if 0'ed code; it gets in the way of grepping for things (florian@) ~ slaacd.c > only mark privacy addresses as such instead of all configured addresses > ok florian@ (naddy@) smtpd ~ smtpd.conf.5 > split the two "listen on" directives into two separate items; > the markup that we were using wouldn;t have worked with groff anyway > but, more worringly, it didn;t work with mandoc either; (jmc@) ~ smtpd.conf.5 > mark up "masquerade"; (jmc@) ~ smtpd.conf.5 > reinstate the description of "mask-source" to "listen on socket": my > changes > two revisions previous inadvertently removed it; > ok gilles (jmc@) tcpdump ~ pfctl_osfp.c > Catch up with pfctl/pfctl_osfp.c, no binary change. > OK deraadt@ (akfaew@) ~ pfctl_osfp.c > Reduce differences between the two pfctl_osfp.c files. > Apply three commits from pfctl/pfctl_osfp.c > OK bluhm@ (akfaew@) traceroute ~ traceroute.c > move as many globals as possible into the main function - thats the > only place where they are used. > Only exception: v6flags - make it an argument to usage() > ok florian@ (benno@) ~ traceroute.c ~ traceroute.h ~ worker.c > introduce struct tr_conf to keep all of the configuration. > Functions needing access to any of those vars get it passed as a parameter. > result: even less global vars. > ok florian@ (benno@) ~ traceroute.c ~ traceroute.h ~ worker.c > check_tos() gets a parameter so i can remove another global var. > ok florian@ (benno@) ~ traceroute.c ~ traceroute.h > style(9) some variable declarations > ok florian@ (benno@) vmd ~ vm.c > SVM: add some exit types > Also, fix a comment that wasn't applicable anymore, and change a format > from decimal to hex (mlarkin@) =============================================================================== _______________________________________________ odc mailing list [email protected] http://www.squish.net/mailman/listinfo/odc
