OpenBSD src changes summary for 2017-07-19 ==========================================
gnu/lib/libobjc gnu/usr.bin/cc lib/libexpat lib/libssl regress/bin regress/sbin regress/usr.bin sbin/iked sbin/pfctl sbin/sysctl share/mk sys/arch/amd64/amd64 sys/arch/i386/i386 sys/arch/sgi/dev sys/dev sys/dev/microcode sys/dev/pci sys/dev/pv sys/dev/usb sys/dev/wscons sys/kern sys/net sys/net80211 sys/nfs usr.bin/bc usr.bin/make usr.bin/mandoc usr.bin/sed usr.bin/ssh usr.bin/systat usr.bin/telnet usr.sbin/httpd usr.sbin/rebound usr.sbin/vmd == gnu =============================================================== 01/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/gnu lib/libobjc ~ Makefile.bsd-wrapper > more depends gc / yacc rules overhaul > okay millert@ (espie@) usr.bin/cc ~ cc_tools/Makefile > more depends gc / yacc rules overhaul > okay millert@ (espie@) == lib =============================================================== 02/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib libexpat ~ Changes ~ README ~ lib/expat.h ~ lib/siphash.h ~ lib/xmlparse.c ~ tests/memcheck.c ~ tests/minicheck.h ~ tests/runtests.c > Update libexpat to 2.2.2. Fixes NULL parser dereference. > no objections deraadt@ (bluhm@) libssl ~ t1_lib.c > Check the return value of CBB_init_fixed(), since it can fail. (jsing@) == regress =========================================================== 03/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/regress bin ~ csh/filec.sh ~ ksh/edit/edit.c ~ ksh/edit/emacs.sh ~ ksh/edit/subr.sh ~ ksh/edit/vi.sh > The first version of the edit program used to test csh, ksh and mail was > based > on the following reasoning: once the program to test has written some data > it > has entered the main-loop and is by now ready to receive user input. At > this > point it should be safe to start writing input and once the program once > again > enters a blocking reading state, its done processing the input. This > approach > was sensitive to timing and determining when a shell is done processing its > input (if ever) is tricky. > This iteration of the edit program takes a new approach and uses presence > of a > prompt for synchronisation of I/O. It doesn't solve all problems but is a > step > in the right direction. > Joint work with bluhm@ (anton@) sbin ~ pfctl/Makefile + pfctl/pf105.in + pfctl/pf106.in + pfctl/pf107.in + pfctl/pf108.in + pfctl/pf109.in + pfctl/pf105.ok + pfctl/pf106.ok + pfctl/pf107.ok + pfctl/pf108.ok + pfctl/pf109.ok + pfctl/pf110.in + pfctl/pf111.in + pfctl/pf110.ok + pfctl/pf111.ok + pfctl/pfail58.in + pfctl/pfail59.in + pfctl/pfail58.ok + pfctl/pfail59.ok + pfctl/pfail60.in + pfctl/pfail61.in + pfctl/pfail62.in + pfctl/pfail60.ok + pfctl/pfail61.ok + pfctl/pfail62.ok > Regression tests asserting various HFSC and FQ-CoDel functionality (mikeb@) usr.bin ~ mail/send.sh > Fix failing tests when executed as a user without a ~/.mailrc configuration > file. > While here, fix a flaky test. (anton@) ~ mail/send.sh > The first version of the edit program used to test csh, ksh and mail was > based > on the following reasoning: once the program to test has written some data > it > has entered the main-loop and is by now ready to receive user input. At > this > point it should be safe to start writing input and once the program once > again > enters a blocking reading state, its done processing the input. This > approach > was sensitive to timing and determining when a shell is done processing its > input (if ever) is tricky. > This iteration of the edit program takes a new approach and uses presence > of a > prompt for synchronisation of I/O. It doesn't solve all problems but is a > step > in the right direction. > Joint work with bluhm@ (anton@) == sbin ============================================================== 04/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin iked ~ Makefile > more depends gc / yacc rules overhaul > okay millert@ (espie@) pfctl ~ parse.y ~ pfctl.c ~ pfctl_queue.c > Rework HFSC vs FQ-CoDel checks > The selection mechanism introduced in pf_ioctl.c -r1.316 suffers > from being too ambiguous and lacks robustness. Instead of relying > on composition of multiple flags in the queue specification, it's > easier to identify the root class (if it exists) and derive all > further checks from it. (mikeb@) ~ parse.y ~ pfctl.c ~ pfctl_parser.c > Allow HFSC classes to use flow queues > The FQ-CoDel related configuration (flows, quantum) becomes available > for the regular bandwidth queue. Internally the kernel will pick the > FQ-CoDel for use as a queue manager for the specified class instead of > the FIFO. > Discussed with and OK henning@ at d2k17 as a part of a larger diff. > (mikeb@) sysctl ~ sysctl.c > revert previous; the code this was supposed to be used for is moving > in the wrong direction. (florian@) == share ============================================================= 05/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share mk ~ bsd.README > 1. The cleandir target no longer deletes manual pages, that's a > remnant from the remote past when we used to install preformatted > manuals. > 2. The list of files deleted by the clean target grew out of date > and was incomplete, but we already know that it will change again > soon, so delete overdocumentation. > Feedback and OK espie@. (schwarze@) ~ bsd.README > Avoid the historical term "loader", consistently talk about the "linker". > Outdated terminology noticed by espie@. (schwarze@) == sys =============================================================== 06/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys arch/amd64/amd64 ~ db_interface.c > Add a enter_ddb() "accessop" to wsdisplay(4) to allow KMS drivers to bypass > the modeset lock when entering ddb. This avoids triggering various asserts > when the kernel panics while running X. > ok deraadt@ (kettenis@) arch/i386/i386 ~ db_interface.c > Add a enter_ddb() "accessop" to wsdisplay(4) to allow KMS drivers to bypass > the modeset lock when entering ddb. This avoids triggering various asserts > when the kernel panics while running X. > ok deraadt@ (kettenis@) arch/sgi/dev ~ if_iec.c > Fix memory leak in iec_get(). If MCLGET fails free the mbuf as well. > Found by Ilja Van Sprundel > OK bluhm@ deraadt@ (claudio@) dev ~ vnd.c > Avoid division by zero of vnd_secsize > Found by Ilja Van Sprundel > ok claudio kettenis (deraadt@) ~ vnd.c > Avoid additional div0 in case both ntracks & nsectors passed in > via ioctl are 0. > Noticed by bluhm > ok bluhm millert (deraadt@) ~ midi.c ~ midivar.h > Remove SIGIO support. The audio(4) driver doesn't implement it either and > the preferred method to access MIDI hardware is through sndiod(8) which > doesn't use it. > Fixes a potential issue with a stale struct proc pointer found by Ilja van > Sprundel. > ok deraadt@, ratchov@ (kettenis@) dev/microcode ~ aic7xxx/Makefile > more depends gc / yacc rules overhaul > okay millert@ (espie@) dev/pci ~ if_vte.c > Fix possible double free in the TX dma ring handling. If the allocation of > the cluster fails in vte_init_tx_ring() the mbuf is removed but the slot > in the ring still holds the pointer. A possible call to vte_stop() would > then cause a double free. Again set pointer to NULL to prevent this. > Found by Ilja Van Sprundel > OK bluhm@ (claudio@) ~ if_et.c > Check if mbuf cluster allocation succeeded and on failure free mbuf and > return ENOBUFS. > Found by Ilja Van Sprundel > OK bluhm@ deraadt@ (claudio@) ~ drm/i915/i915_drv.c > Add a enter_ddb() "accessop" to wsdisplay(4) to allow KMS drivers to bypass > the modeset lock when entering ddb. This avoids triggering various asserts > when the kernel panics while running X. > ok deraadt@ (kettenis@) ~ drm/radeon/radeon_kms.c > Implement the enter_ddb() "accessop" here as well. (kettenis@) ~ drm/drmP.h ~ drm/drm_drv.c ~ drm/i915/i915_drv.h ~ drm/i915/i915_gem.c ~ drm/i915/intel_display.c ~ drm/i915/intel_overlay.c ~ drm/i915/intel_ringbuffer.c > Implement drm_pci_alloc() and drm_pci_free() and use them to reduce the > diffs with Linux. (kettenis@) dev/pv ~ xen.c > Turn this into a panic since there's no way to recover from it (mikeb@) dev/usb ~ if_urndis.c > Add a handler for RNDIS status messages > RNDIS status messages may indicate various conditions reported by > the hardware, including link status events. They're not supposed > to be universally treated as errors. > Issue reported by Artturi Alm, ok armani (mikeb@) dev/wscons ~ wsdisplay.c ~ wsdisplayvar.h > Add a enter_ddb() "accessop" to wsdisplay(4) to allow KMS drivers to bypass > the modeset lock when entering ddb. This avoids triggering various asserts > when the kernel panics while running X. > ok deraadt@ (kettenis@) ~ wsdisplay.c > Fix previous commit; check the enter_ddb function pointer instead of the > "accessops" pointer before calling it. (kettenis@) kern ~ uipc_syscalls.c > Move KTRPOINT call up. The lenght variable i is getting aligned and so > uninitialised data can be dumped into the ktrace message. > Found by Ilja Van Sprundel > OK bluhm@ (claudio@) ~ sys_process.c > Uninitialized variable can leak kernel memory. > Found by Ilja Van Sprundel > ok kettenis (deraadt@) net ~ if_pppoe.c > Fix double free in pppoe_dispatch_disc_pkt(). If m_pulldown() fails m is > freed but another m_freem call happens later. Set m to NULL if m_pulldown() > fails like in all other cases of this function. > Found by Ilja Van Sprundel > OK bluhm@ (claudio@) ~ switchofp.c > The proper way to check for successful allocation of an mbuf cluster is > by checking M_EXT flag. m_freem() the mbuf in the errorcase to prevent > a mbuf leak. MCLGET does not set the mbuf to NULL on failure. > Found by Ilja Van Sprundel > OK bluhm@ deraadt@ (claudio@) ~ pf_ioctl.c ~ pfvar.h > Rework HFSC vs FQ-CoDel checks > The selection mechanism introduced in pf_ioctl.c -r1.316 suffers > from being too ambiguous and lacks robustness. Instead of relying > on composition of multiple flags in the queue specification, it's > easier to identify the root class (if it exists) and derive all > further checks from it. (mikeb@) ~ hfsc.c > Factor out internal FIFO queue manager > HFSC internal queue becomes accessible via pf queueing ops. It will > also select an alternative queue manager based on the queue spec. > Discussed with and OK henning@ at d2k17 as a part of a larger diff. > (mikeb@) ~ hfsc.c > Fix the test condition weakened a recent change (mikeb@) net80211 ~ ieee80211_node.c > Improve the heuristic which selects 5GHz APs over 2GHz APs. > The previous code wasn't quite right: it didn't account for the fact that > some drivers don't set ic_max_rssi, and it compared 5GHz APs to a threshold > relative to the max RSSI, rather than comparing RSSI on 5GHz relative to > RSSI on 2GHz. > This heuristic is only used by SCANNALLBAND drivers: iwn(4), iwm(4), wpi(4) > In the future the AP selection heuristic should be made more intelligent, > e.g. it should take BSS load information in beacons into account. > Another open problem is inconsistent representation of RSSI measurement > values throughout our drivers and stack. Help is welcome! > For now, this hopefully improves AP selection at busy airports. > ok sthen@ deraadt@ (stsp@) ~ ieee80211_ioctl.c ~ ieee80211_ioctl.h > Plug an information leak in ieee80211_node2req(). > Problem reported by Ilja Van Sprundel. > ok tb@ (stsp@) nfs ~ nfs_boot.c > If second xdr_string_encode() fails in bp_getfile() m_freem() m since > this mbuf was allocated by the first call. Fixes possible memory leak. > Found by Ilja Van Sprundel > OK bluhm@ deraadt@ (claudio@) == usr.bin =========================================================== 07/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin bc ~ Makefile ~ scan.l > more depends gc / yacc rules overhaul > okay millert@ (espie@) make ~ Makefile > depend is dead (espie@) mandoc ~ mansearch.c > Prefer arch-dependent over arch-independent pages if the name priority, > the section number, and all names match. Changes little on installed > systems except the ordering of apropos(1) results, because we install > base and Xenocara manuals in different trees, but fixes lookup of pages > like apm(4) vs. apm(4/amd64) in man.cgi(8). > Issue discovered by martian67 on freenode and reported via tj@. (schwarze@) sed ~ sed.1 > remove some spacing; ok schwarze (jmc@) ssh ~ ssh-agent.c > switch from select() to poll() for the ssh-agent mainloop; ok markus (djm@) ~ sshkey.c > fix support for unknown key types; ok djm@ (markus@) systat ~ pftop.c > Allow HFSC classes to use flow queues > The FQ-CoDel related configuration (flows, quantum) becomes available > for the regular bandwidth queue. Internally the kernel will pick the > FQ-CoDel for use as a queue manager for the specified class instead of > the FIFO. > Discussed with and OK henning@ at d2k17 as a part of a larger diff. > (mikeb@) telnet ~ commands.c ~ sys_bsd.c > A few cleanups. This only needs to operate on systems with SIGWINCH, > SIGINFO, and Bxxxx values that equal xxxx. > ok tom millert (deraadt@) == usr.sbin ========================================================== 08/08 == http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin httpd ~ config.c ~ httpd.h ~ server.c > Rework the way that TLS configuration is sent/received via imsgs, so that > are no longer limited by the 16KB maximum size of a single imsg. > Configuration data that is larger than a single message is now chunked and > sent via multiple imsgs. > Prompted by a diff from Jack Burton <jack at saosce dot com dot au>. > ok reyk@ (jsing@) rebound ~ rebound.c > there's no nul byte after a name that ends in a crazy compression pointer. > (tedu@) vmd ~ vmd.8 > Update vmd man page to describe we have more processes running (aside from > one per VM plus "one more") (mlarkin@) ~ vm.conf.5 > Don't recommend using /var/vmm for VM images. > Discussed with deraadt (mlarkin@) =============================================================================== _______________________________________________ odc mailing list [email protected] http://www.squish.net/mailman/listinfo/odc
