Hi Jeremias,
thanks for the quick patch.
Is there any way to check if an OSGi is a valid OSGi? Can we add some
regression test?
Just a quick note on the current sources.
Even before the patch, ODFDOM does not build due to a Javadoc memory
issue. It can be fixed by editing
/trunk/odfdom/pom.xml (the same file Jeremias edited):
Change the Java version from JDK 5 to JDK 6. We switched to JDK 6 to new
encryption / security features.
<artifactId>maven-compiler-plugin</artifactId>
<version>2.3.2</version>
<configuration>
<source>1.6</source>
<target>1.6</target>
Reduce the memory for the JavaDoc plugin and update the version:
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>2.8</version>
<configuration>
<doctitle>ODFDOM</doctitle>
<minmemory>128m</minmemory>
<maxmemory>1024m</maxmemory>
After this the build should run smoothly.
The following is redundant and should be removed:
The directory
/trunk/validator/test
All .hgeol files
/trunk/generator/.hgeol
/trunk/odfdom/.hgeol
/trunk/simple/.hgeol
/trunk/validator/.hgeol
Best regards,
Svante
Am 19.09.2011 17:28, schrieb Jeremias Maerki:
> I've chatted with Svante earlier today and we happened to talk briefly about
> OSGi. I'm using ODFDOM in an OSGi system, so I'm interested that the JAR
> includes OSGi metadata from the start. Since the issue tracker isn't
> available, yet, I'm posting my patch here.
>
> I expect the OSGi part to change slightly as you'll move from
> org.odftoolkit to org.apache but that should be a no-brainer even for
> someone without knowledge about OSGi.
>
> While doing the change, I noticed that odfdom-jar-with-dependencies.jar
> loses the Manifest data compared to odfdom.jar. That is so even without
> my changes. Please note that the single JAR would need different OSGi
> metadata. It can't just be copied over to the assembly. Well, it
> probably can but it beats the purpose of the assembly since it would
> still look for Xerces outside of it own bundle.
>
> Jeremias Maerki (ICLA on file)
