On Wed, Dec 14, 2011 at 1:55 PM, Devin Han <[email protected]> wrote: > Hi Yegor, > > Thanks for your feedback. I will try to fix these issues tomorrow. At the > same time, let's waiting for the feedback from Ruby. > BTW: I have fixed the issues and submitted which pointed out by Nick. > Anyone who interested in it, please help me review it. >
I can take a look at the Java 5 issue. -Rob > 2011/12/14 Yegor Kozlov <[email protected]> > >> Davin, >> >> Sorry for my belated feedback. I have some questions: >> >> (1) The required version of Java should be stated more clearly: >> ODFTollkit requires JDK 1.6+. >> >> The "Getting Started" section of README.txt says "The ODF Toolkit is >> based on Java 5" but this is too broad. I had no luck compiling the >> project under JDK 1.5.22. >> >> >> (2) How are you going to release the Maven artifacts? >> >> Ideally, you stage the release for a vote on the ASF staging repo: >> http://repository.apache.org. This is the recommended way to go for >> Maven-based projects, see >> http://www.apache.org/dev/publishing-maven-artifacts.html >> >> (3) The build process talks too much. I see hundreds of messages >> starting with INFO and WARNING: they seem to come from >> java.util.logging.* which redirects everything to stdout if no loggers >> are defined. This should be easy to correct by placing a >> logging.properties file in the classpath. >> >> I would like to see (1) corrected. (2) and (3) are desirable but if it >> is hard I'm OK to wait until the next release. >> >> >> Yegor >> >> On Tue, Dec 13, 2011 at 4:30 PM, Devin Han <[email protected]> wrote: >> > Thanks again! >> > >> > Hi everybody, we are continuing collect feedback for RC3 before RC4 is >> > ready. So, please keep free give your comments. Then I can update them in >> > RC4 ASAP. >> > >> > Let's work together to make the first release born earlier ;) >> > >> > 2011/12/13 Nick Burch <[email protected]> >> > >> >> On Tue, 13 Dec 2011, Devin Han wrote: >> >> >> >>> Ideally we should have MD5 and SHA1 hashes for all of these files >> >>>> (currently missing) and GPG signatures (only available for the -src). >> Any >> >>>> chance you could upload these too? (These could be added now, it >> wouldn't >> >>>> need a re-vote, but they should be added before release) >> >>>> >> >>>> These files have been generated on my machine, just need submitted. >> It's >> >>> easy. >> >>> >> >> >> >> Great. They're normally included with the artifacts being voted on, as >> >> that's one of the checks people typically do. One to add to the release >> >> documentation :) >> >> >> >> Nick >> >> >> > >> > >> > >> > -- >> > -Devin >> > > > > -- > -Devin
